From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751173AbdALIn0 (ORCPT ); Thu, 12 Jan 2017 03:43:26 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:35153 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdALInX (ORCPT ); Thu, 12 Jan 2017 03:43:23 -0500 MIME-Version: 1.0 In-Reply-To: <20170111221334.26194-1-tony@atomide.com> References: <20170111221334.26194-1-tony@atomide.com> From: Geert Uytterhoeven Date: Thu, 12 Jan 2017 09:43:21 +0100 X-Google-Sender-Auth: heaKPUP-ON6SszE6C4SsxKujEb4 Message-ID: Subject: Re: [PATCH] pinctrl: core: Fix regression caused by delayed work for hogs To: Tony Lindgren Cc: Linus Walleij , Haojian Zhuang , Masahiro Yamada , Grygorii Strashko , Nishanth Menon , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , Gary Bisson , Linux-Renesas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Wed, Jan 11, 2017 at 11:13 PM, Tony Lindgren wrote: > Commit df61b366af26 ("pinctrl: core: Use delayed work for hogs") caused a > regression at least with sh-pfc that is also a GPIO controller as > noted by Geert Uytterhoeven . > > As the original pinctrl_register() has issues calling pin controller > driver functions early before the controller has finished registering, > we can't just revert commit df61b366af26. That would break the drivers > using GENERIC_PINCTRL_GROUPS or GENERIC_PINMUX_FUNCTIONS. > > So let's fix the issue with the following steps as a single patch: > > 1. Revert the late_init parts of commit df61b366af26. > > The late_init clearly won't work and we have to just give up > on fixing pinctrl_register() for GENERIC_PINCTRL_GROUPS and > GENERIC_PINMUX_FUNCTIONS. > > 2. Split pinctrl_register() into two parts > > By splitting pinctrl_register() into pinctrl_init_controller() > and pinctrl_create_and_start() we have better control over when > it's safe to call pinctrl_create(). > > 3. Introduce a new pinctrl_register_and_init() function > > As suggested by Linus Walleij , we > can just introduce a new function for the controllers that need > pinctrl_create() called later. > > 4. Convert the four known problem cases to use new function > > Let's convert pinctrl-imx, pinctrl-single, sh-pfc and ti-iodelay > to use the new function to fix the issues. The rest of the drivers > can be converted later. Let's also update Documentation/pinctrl.txt > accordingly because of the known issues with pinctrl_register(). > > Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs") > Reported-by: Geert Uytterhoeven > Cc: Gary Bisson > Signed-off-by: Tony Lindgren Thanks, this fixes r8a7740/armadillo. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds