From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver
Date: Mon, 18 Feb 2013 11:29:18 +0100 [thread overview]
Message-ID: <CAMuHMdXJ+waZJ95bRLPYYsneXf98c=9d9n1jdkWMKhUpAAB_RA@mail.gmail.com> (raw)
In-Reply-To: <1360955396-14183-1-git-send-email-haiyangz@microsoft.com>
On Fri, Feb 15, 2013 at 8:09 PM, Haiyang Zhang <haiyangz@microsoft.com> wrote:
> +/* Allocate framebuffer memory */
> +#define FOUR_MEGA (4*1024*1024)
> +#define NALLOC 10
> +static void *hvfb_getmem(void)
> +{
> + ulong *p;
> + int i, j;
> + ulong ret = 0;
> +
> + if (screen_fb_size == FOUR_MEGA) {
> + ret = __get_free_pages(GFP_KERNEL|__GFP_ZERO,
> + get_order(FOUR_MEGA));
> + goto out1;
> + }
> +
> + if (screen_fb_size != FOUR_MEGA * 2)
> + return NULL;
> +
> + /*
> + * Windows 2012 requires frame buffer size to be 8MB, which exceeds
> + * the limit of __get_free_pages(). So, we allocate multiple 4MB
> + * chunks, and find out two adjacent ones.
> + */
> + p = kmalloc(NALLOC * sizeof(ulong), GFP_KERNEL);
> + if (!p)
> + return NULL;
> +
> + for (i = 0; i < NALLOC; i++)
> + p[i] = __get_free_pages(GFP_KERNEL|__GFP_ZERO,
> + get_order(FOUR_MEGA));
> +
> + for (i = 0; i < NALLOC; i++)
> + for (j = 0; j < NALLOC; j++) {
> + if (p[j] && p[i] && virt_to_phys((void *)p[j]) -
> + virt_to_phys((void *)p[i]) == FOUR_MEGA &&
> + p[j] - p[i] == FOUR_MEGA) {
> + ret = p[i];
> + goto out;
> + }
> + }
> +
> +out:
> + for (i = 0; i < NALLOC; i++)
> + if (p[i] && !(ret && (p[i] == ret || p[i] == ret + FOUR_MEGA)))
> + free_pages(p[i], get_order(FOUR_MEGA));
> +
> + kfree(p);
> +
> +out1:
> + if (!ret)
> + return NULL;
> +
> + /* Get an extra ref-count to prevent page error when x-window exits */
> + for (i = 0; i < screen_fb_size; i += PAGE_SIZE)
> + atomic_inc(&virt_to_page((void *)ret + i)->_count);
> +
> + return (void *)ret;
> +}
Please instead reserve some memory at boot time, or allocate it very early
(cfr. ps3fb).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2013-02-18 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 19:09 [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver Haiyang Zhang
2013-02-17 14:32 ` Olaf Hering
2013-02-17 19:10 ` Haiyang Zhang
2013-02-18 10:29 ` Geert Uytterhoeven [this message]
2013-02-18 16:09 ` Haiyang Zhang
2013-02-19 16:51 ` Olaf Hering
2013-02-19 17:48 ` Haiyang Zhang
2013-02-19 18:40 ` Olaf Hering
2013-02-19 19:04 ` Haiyang Zhang
2013-02-21 15:53 ` Olaf Hering
2013-02-22 4:11 ` Haiyang Zhang
2013-02-28 15:16 ` Olaf Hering
2013-02-28 17:56 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXJ+waZJ95bRLPYYsneXf98c=9d9n1jdkWMKhUpAAB_RA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=FlorianSchandinat@gmx.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).