From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C296C43381 for ; Mon, 11 Jan 2021 10:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52E7D224D3 for ; Mon, 11 Jan 2021 10:41:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729328AbhAKKlW (ORCPT ); Mon, 11 Jan 2021 05:41:22 -0500 Received: from mail-ot1-f54.google.com ([209.85.210.54]:34125 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbhAKKlV (ORCPT ); Mon, 11 Jan 2021 05:41:21 -0500 Received: by mail-ot1-f54.google.com with SMTP id a109so16470566otc.1; Mon, 11 Jan 2021 02:41:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fQE92wGImoCuHGlTBsuRYfPJyJNJDeXQD1pa+O0heSQ=; b=k3CagimkYb5qti0xPocP9KUUcWHcx57HTW4rxNTMiDtntcJOflk9XuQSFaKrsXryQG VKFQdGQ2KtNcgl7UBf+xmXsHosyL7TgRxvXV/W0TL0t+bgrqheg0g8QdADQTlDAP8r0M pfCEOlCGoVuP1L/Bv1BeAtzDrfOvNcqwYzkgI/+wZ7CoL3SdlFBAkzy5aA1zOivBcKN8 Z4n9bPH8RwZFO+OAdBhBrAJHbnSqKYIXPavjD9BNLEP6WGIQWcXdeZJjmi9Idv73TszC vbn4RpeScyaseBMScBrAFfTWQ7jFRppq0mpLVy+Kge83L6SGNRHeYhAV4Sk9Dtlej9KV qLAQ== X-Gm-Message-State: AOAM531zKhywTZpLSAwkmf4zJE32isxlh+FPfxtQJIef+UvJOYLRkd12 sBN18F/uIUWiUOCUO6/ndNC4KcpOItHbKJXTupE= X-Google-Smtp-Source: ABdhPJw0eeT3HhWAExbemNPOr5fFXG+x/OCUxkL5CeiTn4tO82WpZyRF9+zqWH7caDpH3OcHEW0fc+4bhYFaLcEtYtw= X-Received: by 2002:a05:6830:1f5a:: with SMTP id u26mr10469024oth.250.1610361640322; Mon, 11 Jan 2021 02:40:40 -0800 (PST) MIME-Version: 1.0 References: <20201206214613.444124194@linutronix.de> <20201206220542.062910520@linutronix.de> <87lfcz7pem.fsf@nanos.tec.linutronix.de> In-Reply-To: <87lfcz7pem.fsf@nanos.tec.linutronix.de> From: Geert Uytterhoeven Date: Mon, 11 Jan 2021 11:40:29 +0100 Message-ID: Subject: Re: [patch 5/8] ntp: Make the RTC synchronization more reliable To: Thomas Gleixner Cc: LKML , Alexandre Belloni , Jason Gunthorpe , Miroslav Lichvar , John Stultz , Prarit Bhargava , Alessandro Zummo , linux-rtc@vger.kernel.org, Peter Zijlstra , Wolfram Sang , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Mon, Jan 11, 2021 at 11:12 AM Thomas Gleixner wrote: > On Tue, Dec 29 2020 at 20:41, Geert Uytterhoeven wrote: > >> Reported-by: Miroslav Lichvar > >> Signed-off-by: Thomas Gleixner > > > > Thanks for your patch, which is now commit c9e6189fb03123a7 ("ntp: Make > > the RTC synchronization more reliable"). > > > > Since this commit, the I2C RTC on the R-Car M2-W Koelsch development > > board is accessed every two seconds. Sticking a WARN() in the I2C > > activation path gives e.g. > > Huch? Every two seconds? The timer is armed with 11 * 60 * NSEC_PER_SEC, > which is 11 minutes. Confused.... Thanks for the hint: #define SYNC_PERIOD_NS (11UL * 60 * NSEC_PER_SEC) is truncated on 32-bit platforms. Patch sent. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds