From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbdKMKpM (ORCPT ); Mon, 13 Nov 2017 05:45:12 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:53844 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdKMKpJ (ORCPT ); Mon, 13 Nov 2017 05:45:09 -0500 X-Google-Smtp-Source: AGs4zMYqmsJQrZnPT9TY8VGsjNRx3iFTk5/QLgLT0E4xeI88YkiqI25LJOrRSTegABcSE37vgPJjypCbUHr7tMXfttk= MIME-Version: 1.0 In-Reply-To: References: <7278eca76456b412e02d9baa5dc164e83199cbab.1510118606.git.green.hu@gmail.com> From: Geert Uytterhoeven Date: Mon, 13 Nov 2017 11:45:07 +0100 X-Google-Sender-Auth: pmPm6iMecRKdRbAc-3aiUPgxZ54 Message-ID: Subject: Re: [PATCH 26/31] nds32: Build infrastructure To: Arnd Bergmann Cc: Greentime Hu , greentime@andestech.com, Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 8, 2017 at 11:16 AM, Arnd Bergmann wrote: > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> --- /dev/null >> +++ b/arch/nds32/Kconfig >> @@ -0,0 +1,107 @@ >> +# >> +# For a description of the syntax of this configuration file, >> +# see Documentation/kbuild/kconfig-language.txt. >> +# >> + >> +config NDS32 >> + def_bool y >> + select ARCH_HAS_RAW_COPY_USER >> + select ARCH_WANT_FRAME_POINTERS if FTRACE >> + select ARCH_WANT_IPC_PARSE_VERSION >> + select CLKSRC_MMIO >> + select CLONE_BACKWARDS >> + select TIMER_OF >> + select FRAME_POINTER >> + select GENERIC_ATOMIC64 >> + select GENERIC_CPU_DEVICES >> + select GENERIC_CLOCKEVENTS >> + select GENERIC_IOMAP >> + select GENERIC_IRQ_CHIP >> + select GENERIC_IRQ_PROBE >> + select GENERIC_IRQ_SHOW >> + select GENERIC_STRNCPY_FROM_USER >> + select GENERIC_STRNLEN_USER >> + select GENERIC_TIME_VSYSCALL >> + select HAVE_ARCH_TRACEHOOK >> + select HAVE_GENERIC_IOMAP > > You normally don't want HAVE_GENERIC_IOMAP, at least unless the CPU > has special instructions to trigger PCI I/O port access. GENERIC_IOMAP or HAVE_GENERIC_IOMAP? The latter doesn't even exist, except in Documentation/kbuild/kconfig-language.txt, so it cannot be selected. Given the checks for __NDS32_EB__, NDS32 can be either big or little endian, so you should have (excatly one of) CPU_BIG_ENDIAN or CPU_LITTLE_ENDIAN set. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds