From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR
Date: Mon, 4 Jan 2021 12:05:21 +0100 [thread overview]
Message-ID: <CAMuHMdXWCdKu4HwzyCta4fO0+kbG2HmuZ826DiNsMn5M6+2Ojg@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJVBAE=mh+ZapJ430sYjnwNh-kyMt0P=FjQ=vqjozb7zVA@mail.gmail.com>
Hi Bartosz et al,
On Sun, Jan 3, 2021 at 4:29 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> On Fri, Jan 1, 2021 at 6:07 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > -----Original Message-----
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Sent: 31 December 2020 15:39
> > > To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski
> > > <bgolaszewski@baylibre.com>; Geert Uytterhoeven <geert+renesas@glider.be>
> > > Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > > renesas-soc@vger.kernel.org; Prabhakar <prabhakar.csengg@gmail.com>;
> > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR
> > >
> > > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update
> > > the description to reflect this.
> >
> > Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ???
> >
>
> This looks better IMO - if Geert is OK with that, then let's change it.
"R-Car and RZ/G" sounds better to me, as it is present on all known
R-Car and RZ/G SoCs. We can change the help text if that ever changes.
> > > --- a/drivers/gpio/Kconfig
> > > +++ b/drivers/gpio/Kconfig
> > > @@ -486,11 +486,12 @@ config GPIO_PXA
> > > Say yes here to support the PXA GPIO device
> > >
> > > config GPIO_RCAR
> > > - tristate "Renesas R-Car GPIO"
> > > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support"
> > > depends on ARCH_RENESAS || COMPILE_TEST
> > > select GPIOLIB_IRQCHIP
> > > help
> > > - Say yes here to support GPIO on Renesas R-Car SoCs.
> > > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and
> > > + RZ/G{1,2} SoCs.
> > >
> > > config GPIO_RDA
> > > bool "RDA Micro GPIO controller support"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2021-01-04 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 15:38 [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR Lad Prabhakar
2021-01-01 17:07 ` Biju Das
2021-01-03 15:29 ` Bartosz Golaszewski
2021-01-04 11:05 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXWCdKu4HwzyCta4fO0+kbG2HmuZ826DiNsMn5M6+2Ojg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=bgolaszewski@baylibre.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).