From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752346AbdB1Onp (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 09:43:45 -0500
Received: from mail-it0-f66.google.com ([209.85.214.66]:34873 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751821AbdB1Onn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 09:43:43 -0500
MIME-Version: 1.0
In-Reply-To: <CAK8P3a1e9OZpA6SxDLoaYEUJaR8d_OAr4ai5P2m8kPO7n8THCw@mail.gmail.com>
References: <1488287219-15832-1-git-send-email-geert@linux-m68k.org>
 <1488287219-15832-4-git-send-email-geert@linux-m68k.org> <CAK8P3a1e9OZpA6SxDLoaYEUJaR8d_OAr4ai5P2m8kPO7n8THCw@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 28 Feb 2017 15:43:29 +0100
X-Google-Sender-Auth: Kg22LcNczTXD_jXBWB9vRaGQESQ
Message-ID: <CAMuHMdXaE4Bx3cRvu1-Y+YUvbVVf0qbTfmMZvTH65f2v1Ts2tQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] lib: add module support to linked list sorting tests
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Shuah Khan <shuah@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Tue, Feb 28, 2017 at 3:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Feb 28, 2017 at 2:06 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 90b2348777495b72..32363ae022e3282a 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1731,11 +1731,12 @@ config LKDTM
>>         Documentation/fault-injection/provoke-crashes.txt
>>
>>  config TEST_LIST_SORT
>> -       bool "Linked list sorting test"
>> -       depends on DEBUG_KERNEL
>> +       tristate "Linked list sorting test"
>> +       depends on DEBUG_KERNEL || m
>
> I don't see any other test code with a "DEBUG_KERNEL || m" dependency,
> but several that are "DEBUG_KERNEL && m". Maybe we should just
> force it to be a module like the others? If there are good reasons to
> have it built-in, I'd just drop the "|| m" here.

Some people want to run all tests at boot time, so forcing the test to be
modular breaks that.

I used "|| m" as I like to enable all tests as modules, even when not
using DEBUG_KERNEL.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds