From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26ADAC3B186 for ; Wed, 12 Feb 2020 09:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 093D1206ED for ; Wed, 12 Feb 2020 09:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728939AbgBLJkq (ORCPT ); Wed, 12 Feb 2020 04:40:46 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:41532 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728637AbgBLJkp (ORCPT ); Wed, 12 Feb 2020 04:40:45 -0500 Received: by mail-ot1-f66.google.com with SMTP id r27so1266041otc.8; Wed, 12 Feb 2020 01:40:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iX1QCbzuu3BGmqEDJZWt0cVbMZ3+OMetxQHXkFVuVhI=; b=cujRBEtzxRMhvbCWdkIYWiDWMc5bG6TSUw6aBzCKWflnYi19vP3bajCZWIqIsRjxTL dh8ZzzHNac0bx8kF5KXXxZ/2i8jnkNNbqyT+0PbOnsgQJiUvYAEYnoiEdWLRt0VvqSA3 LwrWk4mWy9NWfCqBPnaLe8fpS2DfgR87qyfyGN8jtsjKP/KqYjy7kMutU7+CImPOt+Xn Gv0fAY2RGHdfMHLxxZ4vmFCeTRJk6XE1yfBYXmDs14JzsVQ4gdm6yLq9qvEyAle/OC9m 2dY2XMLLe88us4JrIoZnJsn6+RVWm97YuiKKFeMqsbpGADjykMdcne7WBFraax5/G819 xSIg== X-Gm-Message-State: APjAAAXwLE/TM9QCFysEtU/xSNYaQOOnpNgr+4t6pSh7Qsav8EHasLX2 47KSyVqAnHJt7TDnoAylVEaCZue7Q4+wrx84dQ4= X-Google-Smtp-Source: APXvYqyWm8J7g3jwnMFPhhMnWSj4FNKlh4z5WFmgTThDSla3CsRQ2YIpRrPhI+DwlVltcq01g4V3ATHZqdn0YcXYbls= X-Received: by 2002:a9d:7984:: with SMTP id h4mr8722956otm.297.1581500444826; Wed, 12 Feb 2020 01:40:44 -0800 (PST) MIME-Version: 1.0 References: <6128aa3a-a99c-2ab0-82d1-d5c419e4f5b9@xilinx.com> <1d006656-bd48-0b8e-b893-cddaa5f8f8bc@xilinx.com> In-Reply-To: <1d006656-bd48-0b8e-b893-cddaa5f8f8bc@xilinx.com> From: Geert Uytterhoeven Date: Wed, 12 Feb 2020 10:40:33 +0100 Message-ID: Subject: Re: [PATCH v2] asm-generic: Fix unistd_32.h generation format To: Michal Simek Cc: Max Filippov , LKML , Michal Simek , git@xilinx.com, Arnd Bergmann , Andrew Morton , Stefan Asserhall , Chris Zankel , "David S. Miller" , Fenghua Yu , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , Matt Turner , Rich Felker , Richard Henderson , Tony Luck , Yoshinori Sato , "open list:ALPHA PORT" , "open list:IA64 (Itanium) PL..." , "open list:M68K ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:SUPERH" , "open list:TENSILICA XTENSA PORT (xtensa)" , "open list:SPARC + UltraSPAR..." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Wed, Feb 12, 2020 at 10:38 AM Michal Simek wrote: > On 12. 02. 20 10:32, Geert Uytterhoeven wrote: > > On Wed, Feb 12, 2020 at 10:27 AM Michal Simek wrote: > >> On 12. 02. 20 10:25, Geert Uytterhoeven wrote: > >>> On Wed, Feb 12, 2020 at 10:23 AM Max Filippov wrote: > >>>> On Wed, Feb 12, 2020 at 1:16 AM Michal Simek wrote: > >>>>> > >>>>> Generated files are also checked by sparse that's why add newline > >>>>> to remove sparse (C=1) warning. > >>>>> > >>>>> The issue was found on Microblaze and reported like this: > >>>>> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45: > >>>>> warning: no newline at end of file > >>>>> > >>>>> Signed-off-by: Michal Simek > >>>>> Reviewed-by: Stefan Asserhall > >>> > >>>>> --- a/arch/m68k/kernel/syscalls/syscallhdr.sh > >>>>> +++ b/arch/m68k/kernel/syscalls/syscallhdr.sh > >>>>> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > >>>>> printf "#endif\n" > >>>>> printf "\n" > >>>>> printf "#endif /* %s */\n" "${fileguard}" > >>>> > >>>> Here there's already \n at the end, so no need for another one? > >>> > >>> Thanks! I completely missed that. > >>> So I did fix the original while applying ;-) > >> > >> I can drop m68k or align with with others. I would prefer to have the > >> same solution in all these scripts. > > > > Yeah, it makes sense to align as much as possible. > > IIRC, the original plan was to consolidate more later. > > > > Note that all other lines are terminated with a "\n" at the end. > > The separate 'printf "\n"' is an extra blank line, not the terminator for the > > previous line. > > Should we also get rid of 'printf "\n"' lines or just keep them as they > are today? Usually there is a blank line above the include guard terminator, so IMHO it makes sense to have that in generated files, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds