From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DF5C4332F for ; Fri, 26 Nov 2021 12:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377338AbhKZMJN (ORCPT ); Fri, 26 Nov 2021 07:09:13 -0500 Received: from mail-ua1-f47.google.com ([209.85.222.47]:46952 "EHLO mail-ua1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349967AbhKZMHM (ORCPT ); Fri, 26 Nov 2021 07:07:12 -0500 Received: by mail-ua1-f47.google.com with SMTP id az37so18061371uab.13; Fri, 26 Nov 2021 04:03:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNC7an2ww+zEf5w3reGfTYHQ6QdOpqUWo1qBddxbOT4=; b=lx/mHMlkaMdUgA52y55EvstnUWrBCJKYrsCirfh3j+iApo5fuDs5t/3j9uVAowY2yR KpZ/NavEtRgYJu4oXuv59v7GTn009EH4hrhW/t3670ibQmQ+/cYXKkMInUrSiUxg+FuA 3TaPSzbUi2z5ne+wVOkz6XpMK6RInH1kfQzcPaOtHuJpX7l8ZDyY8t6YtSqPOCT60BVa w7CumvgzVAZw0bqZMP4GpcyKC5u4B6s1rtjcPu6MM5Q3pAI2KHjx5l8h00OjvkTCpWst rPHNMSsAuhr/0DRxqlgyqGNp6ntx+nbAFxTbuXYqPaLats1wPLa1Lx2NO2S1FJwU/cot EopQ== X-Gm-Message-State: AOAM5323WGZzJGEqZ1IxwPUoZJrS2y+zsp6aKwG11QIgrz35FZZDet/u 5lH5Thkl3g29Gml6wzOjrTYL12oQMmBuLg== X-Google-Smtp-Source: ABdhPJyNclc5OZHOCVtxtWQJKxVjURNmysMp/yS4UIqvPlcWA9gdq9wzNIqaQrU1jTfm/Vta1ySWvg== X-Received: by 2002:a67:c38f:: with SMTP id s15mr15828946vsj.50.1637928238739; Fri, 26 Nov 2021 04:03:58 -0800 (PST) Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com. [209.85.221.170]) by smtp.gmail.com with ESMTPSA id w22sm3618855vsk.11.2021.11.26.04.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Nov 2021 04:03:58 -0800 (PST) Received: by mail-vk1-f170.google.com with SMTP id e27so5812469vkd.4; Fri, 26 Nov 2021 04:03:58 -0800 (PST) X-Received: by 2002:a1f:4641:: with SMTP id t62mr843550vka.0.1637928237768; Fri, 26 Nov 2021 04:03:57 -0800 (PST) MIME-Version: 1.0 References: <20210906102837.2190387-1-martin.kepplinger@puri.sm> <20210906102837.2190387-3-martin.kepplinger@puri.sm> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 26 Nov 2021 13:03:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v9 2/4] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor To: Martin Kepplinger , Sakari Ailus Cc: Pavel Machek , Laurent Pinchart , Mauro Carvalho Chehab , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kernel@puri.sm, Krzysztof Kozlowski , Linux Kernel Mailing List , Linux Media Mailing List , Paul Kocialkowski , phone-devel@vger.kernel.org, Rob Herring , shawnx.tu@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On Fri, Nov 26, 2021 at 11:18 AM Sakari Ailus wrote: > On Fri, Nov 26, 2021 at 11:02:31AM +0100, Martin Kepplinger wrote: > > Am Donnerstag, dem 25.11.2021 um 12:15 +0100 schrieb Geert > > Uytterhoeven: > > > On Mon, Sep 6, 2021 at 12:30 PM Martin Kepplinger > > > wrote: > > > > Document the bindings used for the SK Hynix Hi-846 CMOS camera > > > > driver. > > > > > > > > Signed-off-by: Martin Kepplinger > > > > Reviewed-by: Laurent Pinchart > > > > Reviewed-by: Rob Herring > > > > --- > > > > .../bindings/media/i2c/hynix,hi846.yaml | 120 > > > > ++++++++++++++++++ > > > > 1 file changed, 120 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > new file mode 100644 > > > > index 000000000000..85a8877c2f38 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > @@ -0,0 +1,120 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor > > > > + > > > > +maintainers: > > > > + - Martin Kepplinger > > > > + > > > > +description: |- > > > > + The Hi-846 is a raw image sensor with an MIPI CSI-2 image data > > > > + interface and CCI (I2C compatible) control bus. The output > > > > format > > > > + is raw Bayer. > > > > + > > > > +properties: > > > > + compatible: > > > > + const: hynix,hi846 > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + items: > > > > + - description: Reference to the mclk clock. > > > > + > > > > + assigned-clocks: > > > > + maxItems: 1 > > > > + > > > > + assigned-clock-rates: > > > > + maxItems: 1 > > > > + > > > > + reset-gpios: > > > > + description: Reference to the GPIO connected to the RESETB > > > > pin. Active low. > > > > + maxItems: 1 > > > > + > > > > + shutdown-gpios: > > > > + description: Reference to the GPIO connected to the XSHUTDOWN > > > > pin. Active low. > > > > + maxItems: 1 > > > > + > > > > + vddio-supply: > > > > + description: Definition of the regulator used for the VDDIO > > > > power supply. > > > > + > > > > + vdda-supply: > > > > + description: Definition of the regulator used for the VDDA > > > > power supply. > > > > + > > > > + vddd-supply: > > > > + description: Definition of the regulator used for the VDDD > > > > power supply. > > > > + > > > > + port: > > > > + $ref: /schemas/graph.yaml#/properties/port > > > > + > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + properties: > > > > + data-lanes: > > > > + oneOf: > > > > + - items: > > > > + - const: 1 > > > > + - const: 2 > > > > + - const: 3 > > > > + - const: 4 > > > > + - items: > > > > + - const: 1 > > > > + - const: 2 > > > > + > > > > + required: > > > > + - data-lanes > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - clocks > > > > + - assigned-clocks > > > > + - assigned-clock-rates > > > > + - vddio-supply > > > > + - vdda-supply > > > > + - vddd-supply > > > > + - port > > > > + > > > > +additionalProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + #include > > > > + > > > > + i2c { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + hi846: camera@20 { > > > > + compatible = "hynix,hi846"; > > > > + reg = <0x20>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_csi1>; > > > > + clocks = <&clk 0>; > > > > + assigned-clocks = <&clk 0>; > > > > + assigned-clock-rates = <25000000>; > > > > + vdda-supply = <®_camera_vdda>; > > > > + vddd-supply = <®_camera_vddd>; > > > > + vddio-supply = <®_camera_vddio>; > > > > + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > > > > + shutdown-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>; > > > > + > > > > + port { > > > > + camera_out: endpoint { > > > > + remote-endpoint = <&csi1_ep1>; > > > > + link-frequencies = /bits/ 64 > > > > + <80000000 200000000>; > > > > + data-lanes = <1 2>; > > > > > > "make dt_binding_check": > > > > > > > > > Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.ya > > > ml: > > > camera@20: port:endpoint: Unevaluated properties are not allowed > > > ('link-frequencies', 'data-lanes' were unexpected) > > > From schema: > > > Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > > > Gr{oetje,eeting}s, > > > > > > Geert > > > > > > thanks a lot Geert, but I can't reproduce this on linux-next. Which > > tree did you run it against? > > > > What I *do* see is the following during dtbs_check, so I guess I could > > remove "orientation" and "rotation" from the example, which would be > > kind of sad because these useful properties are not yet too wide know > > anyway in the media device driver world... > > > > /home/martin/dev/purism-forks/linux- > > next/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: > > camera-front@20: 'orientation', 'rotation' do not match any of the > > regexes: 'pinctrl-[0-9]+' > > From schema: /home/martin/dev/purism-forks/linux- > > next/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml > > > > > > if you can be more speicific I'll definitely try to reproduce again > > though. This is reproducible on next-20211126. Is your dt-schema up-to-date? > link-frequencies is present in the example (as it needs to be) but missing > from required properties. I don't know why there's a complaint about > data-lanes though. I also don't know what's wrong with data-lanes (else I would have sent a patch to fix it ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds