* [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3
@ 2019-09-12 10:31 Kieran Bingham
2019-09-12 10:47 ` Kieran Bingham
2019-09-13 8:23 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Kieran Bingham @ 2019-09-12 10:31 UTC (permalink / raw)
To: linux-renesas-soc, Geert Uytterhoeven
Cc: Sergei Shtylyov, Kieran Bingham, Simon Horman,
Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The pwm3 was incorrectly added with a compatible reference to the
renesas,pwm-r8a7790 (H2) due to a single characther ommision.
Fix the compatible string.
Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 2c4ab70e2a39..74c2c0024e45 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -652,7 +652,7 @@
};
pwm3: pwm@e6e33000 {
- compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
+ compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
reg = <0 0xe6e33000 0 8>;
#pwm-cells = <2>;
clocks = <&cpg CPG_MOD 523>;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3
2019-09-12 10:31 [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3 Kieran Bingham
@ 2019-09-12 10:47 ` Kieran Bingham
2019-09-12 12:14 ` Geert Uytterhoeven
2019-09-13 8:23 ` Simon Horman
1 sibling, 1 reply; 4+ messages in thread
From: Kieran Bingham @ 2019-09-12 10:47 UTC (permalink / raw)
To: linux-renesas-soc, Geert Uytterhoeven
Cc: Sergei Shtylyov, Simon Horman, Geert Uytterhoeven, Magnus Damm,
Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 12/09/2019 11:31, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.
Ugh, my apologies :
s/characther/character/
s/ommision/omission/
Please fix up when applying if there's no need to send a v2.
--
Kieran
>
> Fix the compatible string.
>
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
> };
>
> pwm3: pwm@e6e33000 {
> - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> reg = <0 0xe6e33000 0 8>;
> #pwm-cells = <2>;
> clocks = <&cpg CPG_MOD 523>;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3
2019-09-12 10:47 ` Kieran Bingham
@ 2019-09-12 12:14 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-09-12 12:14 UTC (permalink / raw)
To: Kieran Bingham
Cc: Linux-Renesas, Sergei Shtylyov, Simon Horman, Geert Uytterhoeven,
Magnus Damm, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Thu, Sep 12, 2019 at 12:47 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> On 12/09/2019 11:31, Kieran Bingham wrote:
> > The pwm3 was incorrectly added with a compatible reference to the
> > renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Ugh, my apologies :
>
> s/characther/character/
> s/ommision/omission/
>
> Please fix up when applying if there's no need to send a v2.
>
> --
> Kieran
>
>
> >
> > Fix the compatible string.
> >
> > Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.5, with the above fixed.
BTW, looks like PWM on R-Car Gen2 needs more love...
> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -652,7 +652,7 @@
> > };
> >
> > pwm3: pwm@e6e33000 {
> > - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> > reg = <0 0xe6e33000 0 8>;
> > #pwm-cells = <2>;
> > clocks = <&cpg CPG_MOD 523>;
> >
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3
2019-09-12 10:31 [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3 Kieran Bingham
2019-09-12 10:47 ` Kieran Bingham
@ 2019-09-13 8:23 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2019-09-13 8:23 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Geert Uytterhoeven, Sergei Shtylyov,
Geert Uytterhoeven, Magnus Damm, Rob Herring, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Thu, Sep 12, 2019 at 11:31:43AM +0100, Kieran Bingham wrote:
> The pwm3 was incorrectly added with a compatible reference to the
> renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Fix the compatible string.
>
> Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 2c4ab70e2a39..74c2c0024e45 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -652,7 +652,7 @@
> };
>
> pwm3: pwm@e6e33000 {
> - compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> + compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> reg = <0 0xe6e33000 0 8>;
> #pwm-cells = <2>;
> clocks = <&cpg CPG_MOD 523>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-13 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 10:31 [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3 Kieran Bingham
2019-09-12 10:47 ` Kieran Bingham
2019-09-12 12:14 ` Geert Uytterhoeven
2019-09-13 8:23 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).