From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765DCC433EF for ; Fri, 10 Jun 2022 08:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347157AbiFJIKI convert rfc822-to-8bit (ORCPT ); Fri, 10 Jun 2022 04:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347141AbiFJIJ7 (ORCPT ); Fri, 10 Jun 2022 04:09:59 -0400 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947B259BB3; Fri, 10 Jun 2022 01:09:57 -0700 (PDT) Received: by mail-qk1-f173.google.com with SMTP id a184so15838197qkg.5; Fri, 10 Jun 2022 01:09:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pMvWBoJ3lf0+yvRO7v5FIYeENQCaUYUcamzcDsgiV+A=; b=tT9SiF60nx5E66OKnYPm8d+ZECZCZq2AM3hDNGCpCPdkz2C3lkoRMS8PbyKXQdfNDR U6GI9Ua7HLflzBr4raS1o+oNjR/MAaqlnmXVDX/hK3OHwgje0ZMGc94YKyFFDe1ccTBl 1VOHo2pUrNo1M29aQD/kouE5Lp23Q4d/mQyTQZceNXBwt+LTfp1kNPSq2BorFr3Fflsa Vr9DJ3N3dp8y4p31j3AImqhIISz17pzeTWaM7PVlIsUt7oUQoD4upadc9vLnnWItUkdu UkXISOpAnnBoHdbuEOS9M9MmElaS+1XMV2BH2WEhM+92YNa5J2fs68WkyRY90HtqVO0p 93xQ== X-Gm-Message-State: AOAM531wG+pLdRDqxrm5Wo7gbjxKJ2OWtbkPjI1xXTdbEHcJ/zRjL6AN FQOjy2n9NugxJWpGTM6h95olZfQms+m9gQ== X-Google-Smtp-Source: ABdhPJx5TLebrySpOgXAMezPm3AuyOEPQSSGbYRLGo5/TYZehTlxuyu5fVTo+DJKG3R5bDT1+9H2nA== X-Received: by 2002:a05:620a:d83:b0:6a6:5fde:2325 with SMTP id q3-20020a05620a0d8300b006a65fde2325mr29603452qkl.407.1654848596579; Fri, 10 Jun 2022 01:09:56 -0700 (PDT) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id u4-20020a05622a17c400b003051ba1f8bcsm939371qtk.15.2022.06.10.01.09.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 01:09:56 -0700 (PDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-30c143c41e5so264767647b3.3; Fri, 10 Jun 2022 01:09:55 -0700 (PDT) X-Received: by 2002:a81:4811:0:b0:30c:8021:4690 with SMTP id v17-20020a814811000000b0030c80214690mr47131061ywa.47.1654848595616; Fri, 10 Jun 2022 01:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20220609194154.12829-1-wsa+renesas@sang-engineering.com> In-Reply-To: <20220609194154.12829-1-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Fri, 10 Jun 2022 10:09:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support To: Wolfram Sang Cc: Linux-Renesas , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Thu, Jun 9, 2022 at 10:04 PM Wolfram Sang wrote: > Add support for R-Car S4. The S4 IP differs a bit from its siblings in > such way that it has 3 out of 4 TSC nodes for Linux and the interrupts > are not routed to the INTC-AP but to the ECM. > > Signed-off-by: Wolfram Sang > --- > > Change since v1: > > * Describe that this SoC does not require interrupts (Thanks, Geert!) > > I hope dtbs_check is happy now. I can't test it because I get tons of > python install errors when trying to update my dtschema :( Unfortunately not: arch/arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal@e6198000: reg: [[0, 3860430848, 0, 512], [0, 3860463616, 0, 512], [0, 3860496384, 0, 512]] is too short > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Renesas R-Car Gen3 Thermal Sensor > > description: > - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal > - sensors (THS) which are the analog circuits for measuring temperature (Tj) > - inside the LSI. > + > + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) > + control the thermal sensors (THS) which are the analog circuits for > + measuring temperature (Tj) inside the LSI. > > maintainers: > - Niklas Söderlund > @@ -27,6 +28,7 @@ properties: > - renesas,r8a77965-thermal # R-Car M3-N > - renesas,r8a77980-thermal # R-Car V3H > - renesas,r8a779a0-thermal # R-Car V3U > + - renesas,r8a779f0-thermal # R-Car S4 > > reg: true > > @@ -63,6 +65,7 @@ if: > contains: > enum: > - renesas,r8a779a0-thermal > + - renesas,r8a779f0-thermal As this controls both the presence of interrupts and the number of regs. > then: > properties: > reg: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds