From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754717Ab1HZJw0 (ORCPT ); Fri, 26 Aug 2011 05:52:26 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:33693 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803Ab1HZJwW convert rfc822-to-8bit (ORCPT ); Fri, 26 Aug 2011 05:52:22 -0400 MIME-Version: 1.0 In-Reply-To: References: <20110605062702.GA2034@cynthia.pants.nu> Date: Fri, 26 Aug 2011 11:52:21 +0200 X-Google-Sender-Auth: AHJDFig6QCzZIHxnyRyQh9Fvy7s Message-ID: Subject: Re: m68k: Convert to genirq (WIP) From: Geert Uytterhoeven To: Finn Thain Cc: Brad Boyer , "Linux/m68k" , Thomas Gleixner , Linux Kernel Development Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2011 at 12:53, Finn Thain wrote: >> via1_irq >>     OSS_IRQLEV_VIA1 = IRQ_AUTO_6 (on oss)       conflict: psc_irq >> >>     IRQ_AUTO_1                                  conflict: iop_ism_irq >> iop_ism_irq >>     OSS_IRQLEV_IOPISM = 1 = IRQ_AUTO_1 (on oss) conflict: via1_irq > > via1_irq is remapped to IRQ_AUTO_6 on OSS. According to via_register_interrupts(), it requests both: if (via_alt_mapping) { if (request_irq(IRQ_AUTO_1, via1_irq, 0, "software", (void *)via1)) pr_err("Couldn't register %s interrupt\n", "software"); if (request_irq(IRQ_AUTO_6, via1_irq, 0, "via1", (void *)via1)) pr_err("Couldn't register %s interrupt\n", "via1"); } else { if (request_irq(IRQ_AUTO_1, via1_irq, 0, "via1", (void *)via1)) pr_err("Couldn't register %s interrupt\n", "via1"); } Hence IRQ_AUTO_1 must be shared, and we cannot use an optimized chain handler for via1_irq() nor iop_ism_irq(). This is the only remaining conflict I see. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds