From: Geert Uytterhoeven <geert@linux-m68k.org>
To: carmeli.tamir@gmail.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
Nathan Chancellor <natechancellor@gmail.com>,
chrisadr@gentoo.org, areklis909@gmail.com,
Dan Carpenter <dan.carpenter@oracle.com>,
driverdevel <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
Date: Mon, 12 Nov 2018 10:42:47 +0100 [thread overview]
Message-ID: <CAMuHMdXqAbWHCFKD6L_JqJQ1J17=QtopHFihXnWcWufkUJqrTw@mail.gmail.com> (raw)
In-Reply-To: <1541623464-49041-2-git-send-email-carmeli.tamir@gmail.com>
Hi Carmeli,
CC Magnus
(staging drivers receive so may janitorial changes that the original author is
lost in the git shortlog noise)
On Wed, Nov 7, 2018 at 9:46 PM Carmeli Tamir <carmeli.tamir@gmail.com> wrote:
> Added static modifier to the udc_controller, since it's only
> required within emxx_udc.c.
>
> Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Thanks for your patch!
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
>
> /*===========================================================================*/
> /* Global */
> -struct nbu2ss_udc udc_controller;
> +static struct nbu2ss_udc udc_controller;
What about the "Global" comment?
Perhaps this was intentional?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-11-12 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 20:44 [PATCH 0/3] staging: emxx_udc: Fixed all meaningful sparse warnings Carmeli Tamir
2018-11-07 20:44 ` [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
2018-11-12 9:42 ` Geert Uytterhoeven [this message]
2018-11-07 20:44 ` [PATCH 2/3] staging: emxx_udc: Added missing __iomem modifier to handle p_regs Carmeli Tamir
2018-11-07 20:44 ` [PATCH 3/3] staging: emxx_udc: Added missing le16_to_cpu conversions Carmeli Tamir
-- strict thread matches above, loose matches on Subject: below --
2018-11-01 19:58 [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
2018-11-07 11:29 ` Greg KH
2018-10-17 21:01 Carmeli Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXqAbWHCFKD6L_JqJQ1J17=QtopHFihXnWcWufkUJqrTw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=areklis909@gmail.com \
--cc=carmeli.tamir@gmail.com \
--cc=chrisadr@gentoo.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).