From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C81C9C35642 for ; Fri, 21 Feb 2020 09:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9460206EF for ; Fri, 21 Feb 2020 09:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728300AbgBUJya (ORCPT ); Fri, 21 Feb 2020 04:54:30 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:47055 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbgBUJya (ORCPT ); Fri, 21 Feb 2020 04:54:30 -0500 Received: by mail-ot1-f67.google.com with SMTP id g64so1441453otb.13; Fri, 21 Feb 2020 01:54:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6KWuWbwpy5eV1ugbAOKbTPCDhSjq5tBX3gsYSurm6FU=; b=BHOVmoTR9eeC3nzMH+otKaox1Nsqffd4TPTvM59LzjCUZnf5MhN+F1U27K6CNOdZJW a3PdOHHdyIDj/v+YPzj7Pl36hL/YaqWvIbhOb5JFw5vJZqLlxQAypr1n608CMU1Ou4QP n7xupIXb4wCxi9t0O/tl8XotO0ZV8dfPGrc1oRjrjL7donyMaiFJYYCbdKnWtlFZVi66 vz8mjy5Ju4bBJtHRefQl/vGdU0DjA39PYeXDZ1Pm+1a4cBIam7qSl4Q6xpb85vZpBzLq K8KCA+nacJfMpfCghzrVYqtetZvMBIutRVG13LgDMlbJw93hPVFBQ57IefCsi+VEWQJG w6cw== X-Gm-Message-State: APjAAAXHAGtY9nt89wBBaG79rn9vI67xyUt8bgJeZagkx049k39o73Nq eygf0CzKK4gckASVJ2WWY2cfcYAC6n1ypKoeMnU= X-Google-Smtp-Source: APXvYqyhskulP9XNKEDIW8WGFVwSFpIZubz6Szsv+4aJV+5XVybq6Gl2c8lJKMieOTMpUoN9JopRyDO5qSQyZQelS5w= X-Received: by 2002:a9d:dc1:: with SMTP id 59mr27510706ots.250.1582278869027; Fri, 21 Feb 2020 01:54:29 -0800 (PST) MIME-Version: 1.0 References: <20200220172403.26062-1-wsa+renesas@sang-engineering.com> <20200220172403.26062-6-wsa+renesas@sang-engineering.com> In-Reply-To: <20200220172403.26062-6-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Fri, 21 Feb 2020 10:54:18 +0100 Message-ID: Subject: Re: [RFC PATCH 5/7] i2c: of: error message unification To: Wolfram Sang Cc: Linux I2C , Linux-Renesas , linux-i3c@lists.infradead.org, Kieran Bingham , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Luca Ceresoli , Jacopo Mondi , Laurent Pinchart , Vladimir Zapolskiy , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, Thanks for your patch! On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang wrote: > - don't prefix the device if %pOF is provided. That information is > enough. While that information is sufficient to identify the device, using a mix of dev_*() and pr_*("... %pOF...") makes it harder to grep for relevant information in the kernel log. Hence I'm not convinced this is an improvement. > - move the prefix to pr_fmt > - change prefix from "of_i2c" to "i2c_of" because the code was moved > out of the of-domain long ago > > Signed-off-by: Wolfram Sang Nevertheless: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds