From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3790C07E9B for ; Wed, 21 Jul 2021 07:53:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B26E8600D1 for ; Wed, 21 Jul 2021 07:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235485AbhGUHMy (ORCPT ); Wed, 21 Jul 2021 03:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235749AbhGUHKr (ORCPT ); Wed, 21 Jul 2021 03:10:47 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2286AC061768 for ; Wed, 21 Jul 2021 00:51:14 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id l2so1310903qtp.11 for ; Wed, 21 Jul 2021 00:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fPh5HDaC3NW63sKOep74w/15dkj23GMomTPo2I4GDhw=; b=GeesXmQG+7CVMQ6QTsIDB+/F52PWxosGClYlRK86JCSRPaEo9A097xHaGPOsY098Gy xrWTrFFlK11otZlGua6ezmKIjD3Hezx1tprVfiZ/iG5dP6sXc6rZXW36KaeLfqAsDpdz Est8nIU8s8G2ugeReNJgIqUZptBTIdytVztczNJenUOGfAH9MD7xY5VugeKAbbgB03dt dKCNWlvTWBXssbyrIiEVaAzb4cLFsnWzTTKjKRi+IGvcoY+CHa5amWDwr5AZ8itI3E8w D1i+AQHH2HU7DrlShG/wUfyPHh5iNyAGsbNTnnfjmT0cEvdHmft2lvwZnm7DjfnAsygc T2Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fPh5HDaC3NW63sKOep74w/15dkj23GMomTPo2I4GDhw=; b=j2TRjUxqipYrlhUQN94Nu8VdCcjcSSy5f3ituZ61H/cziLmcDboGKF8CiroT0bOdaH bNzZ8F9+jEIcc9krs5c7Ro9dCjWUJeR/ec1Sd+QucWvFpEwIxVQgYXHRQoMlUpR0fq8r DQXKy9b7D1lDXQWEqeJ3by/uFYVB+zhmGoYTbum7ihjijd7Tavmp5biJghbXC81ffCg7 eMsDu4/+phzODM1y6LqRqfhNvEOsS8TiJoeGF64yVIfqxAI03CYXmXs8BdpyfRGxisKD 862WrAfaVqs26jelCTSCCpOUT7y8xsduKUkPIXIoH82bkf1Ta5Vyblmw+RML4O8kzuPY FApg== X-Gm-Message-State: AOAM530a4HvP1iMYtvkMitEZQBi61fLxQ0l0v5a9IFm2+O20BRKjqB7U J70fQmiWjCu1K305Pqm/7h3p+ixpyj375emCtYvlbg== X-Google-Smtp-Source: ABdhPJxuzYwcKE9v7oGs3UREu1WAf08RLSGca69xQOyr3PRedUcyn2cJAVDrjrhmRHUPOnTskWIHCnDMDsvvQnUrlK8= X-Received: by 2002:ac8:5645:: with SMTP id 5mr30183956qtt.200.1626853873268; Wed, 21 Jul 2021 00:51:13 -0700 (PDT) MIME-Version: 1.0 References: <20210618195033.3209598-1-grzegorz.jaszczyk@linaro.org> In-Reply-To: <20210618195033.3209598-1-grzegorz.jaszczyk@linaro.org> From: Grzegorz Jaszczyk Date: Wed, 21 Jul 2021 09:51:02 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] introduce watchdog_dev_suspend/resume To: wim@linux-watchdog.org, Guenter Roeck , shawnguo@kernel.org Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Jun 2021 at 21:50, Grzegorz Jaszczyk wrote: > > Hi All, > > The following is a v2 version of the series [1] that fixes system hang which > occurs when the ping worker fires after wdog suspend and before wdog resume. > This happens because the ping worker can issue low-level ping while the wdog clk > was disabled by the suspend routine (accessing hw wdog registers while they are > not fed by the clk). > > To overcome this issue two patches were introduced. Patch #1 introduces pm > notifier in the watchdog core which will call watchdog_dev_suspend/resume and > actually cancel ping worker during suspend and restore it back, if needed, > during resume. > > Patch #2 introduces relevant changes to imx2_wdt driver and notifies wdog core > to stop ping worker on suspend. > > [1] https://lkml.org/lkml/2021/6/15/542 > > Best regards, > Grzegorz > > Grzegorz Jaszczyk (2): > watchdog: introduce watchdog_dev_suspend/resume > watchdog: imx2_wdg: notify wdog core to stop ping worker on suspend > > drivers/watchdog/imx2_wdt.c | 1 + > drivers/watchdog/watchdog_core.c | 37 +++++++++++++++++++++++++ > drivers/watchdog/watchdog_dev.c | 47 ++++++++++++++++++++++++++++++++ > include/linux/watchdog.h | 10 +++++++ > 4 files changed, 95 insertions(+) > > -- > 2.29.0 > Hi, Gentle reminder about this patch-set. Both patches were reviewed by Guenter Roeck and are on the list for some time, I would be happy if we could get them applied. Thank you in advance, Grzegorz