From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756128AbcCQB6c (ORCPT ); Wed, 16 Mar 2016 21:58:32 -0400 Received: from mail-yw0-f169.google.com ([209.85.161.169]:36105 "EHLO mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbcCQB63 (ORCPT ); Wed, 16 Mar 2016 21:58:29 -0400 MIME-Version: 1.0 In-Reply-To: <1458130190.6570.6.camel@suse.com> References: <11ce6df3eb8a95cfed26f3321f15c98a934db642.1458128215.git.baolin.wang@linaro.org> <1458130190.6570.6.camel@suse.com> Date: Thu, 17 Mar 2016 09:58:28 +0800 Message-ID: Subject: Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework From: Baolin Wang To: Oliver Neukum Cc: Felipe Balbi , Greg KH , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Peter Chen , Alan Stern , r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com, Lee Jones , Mark Brown , ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org, USB , device-mainlining@lists.linuxfoundation.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 March 2016 at 20:09, Oliver Neukum wrote: > On Wed, 2016-03-16 at 19:46 +0800, Baolin Wang wrote: >> This patch introduces the usb charger driver based on usb gadget that >> makes an enhancement to a power driver. It works well in practice but >> that requires a system with suitable hardware. >> >> The basic conception of the usb charger is that, when one usb charger >> is added or removed by reporting from the usb gadget state change or >> the extcon device state change, the usb charger will report to power >> user to set the current limitation. > > This patch adds sysfs attributes without adding Documentation for them. > That's bad. I'll add Documentation for the sysfs attributes in next version patchset. Thanks for your comments. -- Baolin.wang Best Regards