From: Baolin Wang <baolin.wang@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer
Date: Wed, 31 Aug 2016 11:18:18 +0800 [thread overview]
Message-ID: <CAMz4ku+=OvjKtA6ciQT1zfJOaAhsbcQEA9+7czw7snm0gfd_9w@mail.gmail.com> (raw)
In-Reply-To: <20160830114230.2f4bce51@gandalf.local.home>
Hi Steven,
On 30 August 2016 at 23:42, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 30 Aug 2016 19:50:20 +0800
> Baolin Wang <baolin.wang@linaro.org> wrote:
>
>> Hi,
>>
>> On 22 August 2016 at 12:23, Baolin Wang <baolin.wang@linaro.org> wrote:
>> > For system debugging, we usually want to know who sets one alarm timer, the
>> > time of the timer, when the timer started and fired and so on. Thus adding
>> > tracepoints can help us trace the alarmtimer information.
>> >
>> > For example, when we debug the system supend/resume, if the system is always
>> > resumed by RTC alarm, we can find out which process set the alarm timer to
>> > resume system by below trace log:
>> >
>> > ......
>> > Binder:2976_6-3473 [005] d..2 1076.587732: alarmtimer_start: process:Binder:2976_6
>> > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
>> >
>> > Binder:2976_7-3480 [002] d..2 1076.592707: alarmtimer_cancel: process:Binder:2976_7
>> > alarmtimer type:ALARM_BOOTTIME expires:1325463060000000000 time: 2012-1-2 0:11:0
>> >
>> > Binder:2976_7-3480 [002] d..2 1076.592731: alarmtimer_start: process:Binder:2976_7
>> > alarmtimer type:ALARM_BOOTTIME expires:1325378040000000000 time: 2012-1-1 0:34:0
>> >
>> > system_server-2976 [003] d..2 1076.605587: alarmtimer_cancel: process:system_server
>> > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
>> >
>> > system_server-2976 [003] d..2 1076.605608: alarmtimer_start: process:system_server
>> > alarmtimer type:ALARM_BOOTTIME expires:1234155000000 time: 1970-1-1 0:20:35
>> >
>> > system_server-3000 [002] ...1 1087.737565: alarmtimer_suspend: alarmtimer type:ALARM_BOOTTIME
>> > expires time: 2012-1-1 0:34:0
>> > ......
>> >
>> > From the trace log, we can find out the 'Binder:2976_7' process set one alarm
>> > timer which resumes the system.
>>
>> Do you have any comments about this patch? Thanks.
>
> Looks fine to me.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Now you need to get the time maintainers to accept it.
Thanks.
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2016-08-31 3:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 4:23 [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer Baolin Wang
2016-08-30 11:50 ` Baolin Wang
2016-08-30 15:42 ` Steven Rostedt
2016-08-31 3:18 ` Baolin Wang [this message]
2016-08-30 18:58 ` John Stultz
2016-08-31 5:29 ` Baolin Wang
2016-10-11 10:48 Baolin Wang
2016-10-17 19:03 ` Steven Rostedt
2016-10-18 2:24 ` Baolin Wang
2016-10-11 10:51 Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMz4ku+=OvjKtA6ciQT1zfJOaAhsbcQEA9+7czw7snm0gfd_9w@mail.gmail.com' \
--to=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).