From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C08C3A5A2 for ; Tue, 3 Sep 2019 09:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75462077B for ; Tue, 3 Sep 2019 09:21:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mcK3nweo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbfICJVH (ORCPT ); Tue, 3 Sep 2019 05:21:07 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:33892 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbfICJVG (ORCPT ); Tue, 3 Sep 2019 05:21:06 -0400 Received: by mail-oi1-f193.google.com with SMTP id g128so12262776oib.1 for ; Tue, 03 Sep 2019 02:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=glcXCjwyqn+HnwC7gVzkRUcxL2AdvVixrYcSTi4w1PU=; b=mcK3nweohShcW2LEUMICZbVwxHtOCjxDYckZO4FfQk37KTz/3nkpuLr77dDXYzZxz4 or6nYv7Vg04A1VkSOntYcSGuOqoqBc18fkMHF5EOKyAIqXvwp60PwkudRRdzqpEHTOFk JLUS6thW/ybzyOX6jTAyx3Unl97exqbMOO6GeRaRFWf1SY5GCKm30eGiO8rfMkr3asm9 n9ZKT/aUSiJNjGdOwETM2FY7y6I/HELN4jGiEPOdSvReA9SfLXUItg4zcRumbYr8rFLS AISiYddP9X8DEDcdhNBOCX3wfjYOsXuM5YhVNqcg7RQCwdHTaQXTkVVoWXBZTuA8RhFS X7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=glcXCjwyqn+HnwC7gVzkRUcxL2AdvVixrYcSTi4w1PU=; b=rP4fa7GUJC+pa07gNsht45LjHBHLf0D80NPWMkMfeiA7ogto91y5NRd60TsvEMGhjb sjlxDwNlNyuOjYRTBCnWp7l5sYSgfsMNP445npTux/ILxxykCHXB6hpLO82+7aOngpCU plH+C83rwchhXc7j7xQz9CUIQn/P5REbCjktmZcZqHXKcvD2NqHcC65liZDrJEwugPI9 +9GGrcePlGo9he31lyt9mSmMIbTSAh34uvv6s13mKKusjUc7XE/re2JYey3okFH3ys7D 2uyAdEdM0ChNY3yfI5qPsSg1u5QBSvwwOjzdsCrMvTqom4Js+exqwbMHIUx/WZmS+D5u tJZA== X-Gm-Message-State: APjAAAV15wjnKY7wlUvQc7z9n8BdQmn7q5qPn/40lW/rWX5ZGh0Z5m9c W6Wa1kk0X7Vk23qgnG9GCjrscbEElJP5ntAqgjgRSg== X-Google-Smtp-Source: APXvYqzo2nUjiHesbwnB0H1Z1h3L+spUHg2mts+oMbRKV6XXnJiqEYS55mFoFRlt4i5wbRS3LbqfxQhk9ndU172nJWQ= X-Received: by 2002:aca:e183:: with SMTP id y125mr14148339oig.27.1567502465778; Tue, 03 Sep 2019 02:21:05 -0700 (PDT) MIME-Version: 1.0 References: <20190826072929.7696-1-zhang.lyra@gmail.com> In-Reply-To: <20190826072929.7696-1-zhang.lyra@gmail.com> From: Baolin Wang Date: Tue, 3 Sep 2019 17:20:54 +0800 Message-ID: Subject: Re: [PATCH 0/3] keep console alive even if missing the 'enable' clock To: Chunyan Zhang Cc: Greg Kroah-Hartman , Jiri Slaby , Orson Zhai , linux-serial@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Aug 2019 at 15:29, Chunyan Zhang wrote: > > From: Chunyan Zhang > > After the commit 4007098f4ce4 (serial: sprd: Add power management for the Spreadtrum serial controller), > the 'enable' clock was forced to be configured in device tree, otherwise the uart devices couldn't be > probed successfully. > > With this patch-set, the uart device which is used as console would be allowed to register even without > any clock configured in device tree, this will make debug easier. Tested on my board, works well and looks good to me. So for the whole series: Reviewed-by: Baolin Wang Tested-by: Baolin Wang > > Chunyan Zhang (3): > serial: sprd: check the right port and membase > serial: sprd: add console_initcall in sprd's uart driver > serial: sprd: keep console alive even if missing the 'enable' clock > > drivers/tty/serial/sprd_serial.c | 42 ++++++++++++++++++++++++++------ > 1 file changed, 34 insertions(+), 8 deletions(-) > > -- > 2.20.1 > -- Baolin Wang Best Regards