From: Baolin Wang <baolin.wang@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
riteshh@codeaurora.org, asutoshd@codeaurora.org,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] mmc: host: sdhci: Add virtual command queue support
Date: Mon, 9 Sep 2019 20:11:35 +0800 [thread overview]
Message-ID: <CAMz4kuJp38Y20XHpF5vm0bwFK3MQK8bqJNtgwgqeXu_FcdpikQ@mail.gmail.com> (raw)
In-Reply-To: <5594efd0-6076-bbb5-5aec-a6b3a21dd7ca@intel.com>
Hi Adrian,
On Mon, 9 Sep 2019 at 20:04, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 6/09/19 6:52 AM, Baolin Wang wrote:
> > Add cqhci_virt_finalize_request() to help to complete a request
> > from virtual command queue.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> > ---
> > drivers/mmc/host/sdhci.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> > index 4e9ebc8..fb5983e 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -32,6 +32,7 @@
> > #include <linux/mmc/slot-gpio.h>
> >
> > #include "sdhci.h"
> > +#include "cqhci.h"
> >
> > #define DRIVER_NAME "sdhci"
> >
> > @@ -2710,7 +2711,8 @@ static bool sdhci_request_done(struct sdhci_host *host)
> >
> > spin_unlock_irqrestore(&host->lock, flags);
> >
> > - mmc_request_done(host->mmc, mrq);
> > + if (!cqhci_virt_finalize_request(host->mmc, mrq))
> > + mmc_request_done(host->mmc, mrq);
>
> Please add a sdhci_ops callback for request->done then:
>
> if (host->ops->request_done)
> host->ops->request_done(host, mrq);
> else
> mmc_request_done(host->mmc, mrq);
Sure, will do.
>
> >
> > return false;
> > }
> > @@ -3133,7 +3135,8 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
> >
> > /* Process mrqs ready for immediate completion */
> > for (i = 0; i < SDHCI_MAX_MRQS; i++) {
> > - if (mrqs_done[i])
> > + if (mrqs_done[i] &&
> > + !cqhci_virt_finalize_request(host->mmc, mrqs_done[i]))
>
> sdhci does not support calling mmc->ops->request in interrupt context.
> So probably, you should avoid immediate completion.
Yes, I missed this, will remove. Thanks.
--
Baolin Wang
Best Regards
prev parent reply other threads:[~2019-09-09 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 3:51 [PATCH 0/4] Add MMC virtual command queue support Baolin Wang
2019-09-06 3:51 ` [PATCH 1/4] mmc: host: cqhci: Move the struct cqhci_slot into header file Baolin Wang
2019-09-06 3:52 ` [PATCH 2/4] mmc: Add virtual command queue support Baolin Wang
2019-09-09 12:01 ` Adrian Hunter
2019-09-09 12:16 ` Baolin Wang
2019-09-09 12:43 ` Adrian Hunter
2019-09-10 3:27 ` Baolin Wang
2019-09-06 3:52 ` [PATCH 3/4] mmc: host: sdhci-sprd: " Baolin Wang
2019-09-06 3:52 ` [PATCH 4/4] mmc: host: sdhci: " Baolin Wang
2019-09-09 12:03 ` Adrian Hunter
2019-09-09 12:11 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuJp38Y20XHpF5vm0bwFK3MQK8bqJNtgwgqeXu_FcdpikQ@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=asutoshd@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=riteshh@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).