From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934050AbcLUH5L (ORCPT ); Wed, 21 Dec 2016 02:57:11 -0500 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33745 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcLUH5J (ORCPT ); Wed, 21 Dec 2016 02:57:09 -0500 MIME-Version: 1.0 In-Reply-To: <585A2F61.20403@samsung.com> References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <767c3dfccde4807e3645951d4aeebca0ab5cc5e4.1482300213.git.baolin.wang@linaro.org> <585A2F61.20403@samsung.com> From: Baolin Wang Date: Wed, 21 Dec 2016 15:57:07 +0800 Message-ID: Subject: Re: [PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set To: Chanwoo Choi Cc: myungjoo.ham@samsung.com, Chen-Yu Tsai , Kishon , =?UTF-8?Q?Heiko_St=C3=BCbner?= , LKML , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Linaro Kernel Mailman List , Mark Brown , NeilBrown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBL7vGfY014534 Hi, On 21 December 2016 at 15:29, Chanwoo Choi wrote: > Hi, > > On 2016년 12월 21일 15:10, Baolin Wang wrote: >> According to the documentation, we should set the EXTCON_USB when >> one SDP charger connector was reported. >> >> Signed-off-by: Baolin Wang >> --- >> drivers/phy/phy-rockchip-inno-usb2.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c >> index 2f99ec9..71fbe0f 100644 >> --- a/drivers/phy/phy-rockchip-inno-usb2.c >> +++ b/drivers/phy/phy-rockchip-inno-usb2.c >> @@ -595,9 +595,14 @@ static void rockchip_usb2phy_otg_sm_work(struct work_struct *work) >> if (rport->vbus_attached != vbus_attach) { >> rport->vbus_attached = vbus_attach; >> >> - if (notify_charger && rphy->edev) >> + if (notify_charger && rphy->edev) { >> extcon_set_cable_state_(rphy->edev, >> cable, vbus_attach); >> + if (cable == EXTCON_CHG_USB_SDP) >> + extcon_set_cable_state_(rphy->edev, >> + EXTCON_USB, >> + vbus_attach); >> + } >> } >> break; >> case OTG_STATE_B_PERIPHERAL: >> > > Looks good to me. But I prefer to use the 'extcon_set_state_sync' intead of extcon_set_cable_state_(). > Reviewed-by: Chanwoo Choi > > I sent the patches[1] for extcon API to alter the deprecated API. > If you possible, I'd like you to alter the extcon API instead of deprecated API. Okay, I will change to extcon_set_state_sync() in next version patch. Thanks. > [1] https://patchwork.kernel.org/patch/9453645/ > - extcon_set_cable_state_() -> extcon_set_state_sync() > - extcon_get_cable_state_() -> extcon_get_state() > - Use devm_extcon_register_notifier() instead of extcon_register_notifier(). > > -- > Regards, > Chanwoo Choi -- Baolin.wang Best Regards