From: Baolin Wang <baolin.wang@linaro.org>
To: Peter Chen <peter.chen@freescale.com>
Cc: Felipe Balbi <balbi@ti.com>, Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
sojka@merica.cz, Alan Stern <stern@rowland.harvard.edu>,
andreas@gaisler.com, linux-usb@vger.kernel.org,
device-mainlining@lists.linuxfoundation.org
Subject: Re: [PATCH 2/2] gadget: Support for the usb charger framework
Date: Fri, 7 Aug 2015 16:46:31 +0800 [thread overview]
Message-ID: <CAMz4kuL1gKjtSgbCPdp4q0xFg1_UXtEcpDHok0vzYajtx4hjNg@mail.gmail.com> (raw)
In-Reply-To: <20150807054554.GE13200@shlinux2>
On 7 August 2015 at 13:45, Peter Chen <peter.chen@freescale.com> wrote:
> On Thu, Aug 06, 2015 at 03:03:49PM +0800, Baolin Wang wrote:
>> The usb charger framework is based on usb gadget, and each usb gadget
>> can be one usb charger to set the current limitation.
>>
>> This patch adds a notifier mechanism for usb charger to report to usb
>> charger when the usb gadget state is changed.
>>
>> Also we introduce a callback 'get_charger_type' which will implemented
>> by user for usb gadget operations to get the usb charger type.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> ---
>> drivers/usb/gadget/udc/udc-core.c | 41 +++++++++++++++++++++++++++++++++++++
>> include/linux/usb/gadget.h | 20 ++++++++++++++++++
>> 2 files changed, 61 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
>> index d69c355..d5368088 100644
>> --- a/drivers/usb/gadget/udc/udc-core.c
>> +++ b/drivers/usb/gadget/udc/udc-core.c
>> @@ -28,6 +28,7 @@
>> #include <linux/usb/ch9.h>
>> #include <linux/usb/gadget.h>
>> #include <linux/usb.h>
>> +#include <linux/usb/usb_charger.h>
>>
>> /**
>> * struct usb_udc - describes one usb device controller
>> @@ -127,12 +128,45 @@ void usb_gadget_giveback_request(struct usb_ep *ep,
>> }
>> EXPORT_SYMBOL_GPL(usb_gadget_giveback_request);
>>
>> +int usb_gadget_register_notify(struct usb_gadget *gadget,
>> + struct notifier_block *nb)
>> +{
>> + unsigned long flags;
>> + int ret;
>> +
>> + spin_lock_irqsave(&gadget->lock, flags);
>
> I find you use so many spin_lock_irqsave, any reasons for that?
> Why mutex_lock can't be used?
>
The spin_lock_irqsave() can make it as a atomic notifier, that can
make sure the gadget state event can be quickly reported to the user
who register a notifier on the gadget device. Is it OK?
> --
>
> Best Regards,
> Peter Chen
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2015-08-07 8:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 7:03 [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2015-08-06 7:03 ` [PATCH 1/2] gadget: Introduce the usb charger framework Baolin Wang
2015-08-06 16:39 ` Greg KH
2015-08-06 18:30 ` Mark Brown
2015-08-07 5:48 ` Baolin Wang
2015-08-07 5:41 ` Peter Chen
2015-08-07 8:33 ` Baolin Wang
2015-08-06 7:03 ` [PATCH 2/2] gadget: Support for " Baolin Wang
2015-08-07 5:45 ` Peter Chen
2015-08-07 8:46 ` Baolin Wang [this message]
2015-08-07 9:07 ` Peter Chen
2015-08-07 9:22 ` Baolin Wang
2015-08-07 17:53 ` Greg KH
2015-08-08 6:23 ` Baolin Wang
2015-08-06 16:21 ` [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi
2015-08-06 16:39 ` Greg KH
2015-08-07 5:34 ` Peter Chen
2015-08-07 8:19 ` Baolin Wang
2015-08-07 8:31 ` Peter Chen
2015-08-07 8:47 ` Baolin Wang
2015-08-07 17:52 ` Greg KH
2015-08-08 6:22 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuL1gKjtSgbCPdp4q0xFg1_UXtEcpDHok0vzYajtx4hjNg@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=andreas@gaisler.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=device-mainlining@lists.linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=sojka@merica.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).