From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754723AbeDWKbk (ORCPT ); Mon, 23 Apr 2018 06:31:40 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33939 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754466AbeDWKbd (ORCPT ); Mon, 23 Apr 2018 06:31:33 -0400 X-Google-Smtp-Source: AIpwx4+PbVOo2U8a9OqPp2zeW7PNtg5j/beXCqNxP0BwTa5g0kk6CFMi827onkYU7FrTbqHAMRbIzvV1uS8DGvp2pVM= MIME-Version: 1.0 In-Reply-To: References: <0ca46228311ec615947e199def9fed62d70c1f07.1524118799.git.baolin.wang@linaro.org> From: Baolin Wang Date: Mon, 23 Apr 2018 18:31:32 +0800 Message-ID: Subject: Re: [PATCH] m68k: Remove read_persistent_clock() To: Geert Uytterhoeven Cc: Arnd Bergmann , Alexandre Belloni , Mark Brown , linux-m68k , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 23 April 2018 at 17:07, Geert Uytterhoeven wrote: > Hi Baolin, > > On Mon, Apr 23, 2018 at 4:08 AM, Baolin Wang wrote: >> On 20 April 2018 at 23:22, Arnd Bergmann wrote: >>> On Thu, Apr 19, 2018 at 8:22 AM, Baolin Wang wrote: >>>> The read_persistent_clock() uses a timespec, which is not year 2038 safe >>>> on 32bit systems. Moreover on m68k architecture, we have implemented generic >>>> RTC drivers that can be used to compensate the system suspend time. So >>>> we can remove the obsolete read_persistent_clock(). >>>> >>>> Signed-off-by: Baolin Wang >>> >>> I'm not sure about this one: it's still possible to turn off >>> CONFIG_RTC_DRV_GENERIC >>> on M68KCLASSIC, and in that case we still need a read_persistent_clock64() >>> implementation. Or we use your patch but make CONFIG_RTC_DRV_GENERIC >>> mandatory. >> >> OK. Thanks for fixing the issue with your patch. > > Can I consider that an Acked-by? I will add one reviewed-by tag in Arnd's new patch. -- Baolin.wang Best Regards