From: Baolin Wang <baolin.wang@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Moore <pmoore@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Kees Cook <keescook@chromium.org>,
John Johansen <john.johansen@canonical.com>,
casey@schaufler-ca.com, agruenba@redhat.com,
Alexander Viro <viro@zeniv.linux.org.uk>,
Neil Brown <neilb@suse.de>,
jann@thejh.net, Mark Brown <broonie@kernel.org>,
Christopher Hall <christopher.s.hall@intel.com>,
Xunlei Pang <pang.xunlei@linaro.org>,
Harald Geyer <harald@ccbib.org>, Arnd Bergmann <arnd@arndb.de>,
lkml <linux-kernel@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64()
Date: Tue, 19 Apr 2016 10:02:00 +0800 [thread overview]
Message-ID: <CAMz4kuLjwzaU81hzV5e7SiPe9SU8aCAHpxusq8+CNGQJenb+Aw@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLXi=+1fOmabeO9o4q_mOcGuDFdxEvEvz3dWEW+g0fkVHw@mail.gmail.com>
On 19 April 2016 at 00:54, John Stultz <john.stultz@linaro.org> wrote:
> On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@linaro.org> wrote:
>> security_settime() uses a timespec, which is not year 2038 safe
>> on 32bit systems. Thus this patch introduces the security_settime64()
>> function with timespec64 type. We also convert the cap_settime() helper
>> function to use the 64bit types.
>>
>> Move the security_settime() to the head file as a inline function for
>> removing that inline helper when following up patches are fixed the
>> call sites.
>>
>> None of the existing hooks is using the timespec argument and therefor
>> the patch is not doing any functional changes.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>
> Hey Baolin,
> If you get an ack, like you did from James, please include it in the
> commit message of following submissions
Ah, sorry, I forgot that. Do I need to resend it with James ack? Thanks.
>
> Serge, Kees: Any objection to this patch going in via the
> tip/timers/core tree with the dependent settimeofday64 call?
>
> Otherwise I'll queue this up for testing.
>
> thanks
> -john
>
>
> .
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2016-04-19 2:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 1:44 [PATCH v2 0/5] Introduce 64bit accessors and structures required to address y2038 issues in the posix_clock subsystem Baolin Wang
2015-07-29 11:58 ` [PATCH v2 1/5] time: Introduce struct itimerspec64 Baolin Wang
2015-07-29 12:09 ` [PATCH v2 2/5] timekeeping: Introduce current_kernel_time64() Baolin Wang
2015-07-29 12:13 ` [PATCH v2 3/5] security: Introduce security_settime64() Baolin Wang
2015-07-30 8:23 ` James Morris
2016-04-18 16:01 ` [RESEND PATCH " Arnd Bergmann
2016-04-18 16:31 ` Mark Brown
2016-04-19 1:57 ` Baolin Wang
2016-04-18 16:54 ` John Stultz
2016-04-18 17:04 ` Kees Cook
2016-04-19 19:59 ` Serge E. Hallyn
2016-04-19 2:02 ` Baolin Wang [this message]
2015-07-29 12:16 ` [PATCH v2 4/5] time: Introduce do_sys_settimeofday64() Baolin Wang
2015-07-29 12:18 ` [PATCH v2 5/5] time: Introduce timespec64_to_jiffies()/jiffies_to_timespec64() Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuLjwzaU81hzV5e7SiPe9SU8aCAHpxusq8+CNGQJenb+Aw@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=agruenba@redhat.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=christopher.s.hall@intel.com \
--cc=harald@ccbib.org \
--cc=james.l.morris@oracle.com \
--cc=jann@thejh.net \
--cc=john.johansen@canonical.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=neilb@suse.de \
--cc=pang.xunlei@linaro.org \
--cc=pmoore@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).