linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Gerst <brgerst@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Usama Arif <usama.arif@bytedance.com>,
	tglx@linutronix.de, kim.phillips@amd.com,
	piotrgorski@cachyos.org, oleksandr@natalenko.name,
	arjan@linux.intel.com, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
	pbonzini@redhat.com, paulmck@kernel.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com,
	thomas.lendacky@amd.com, seanjc@google.com,
	pmenzel@molgen.mpg.de, fam.zheng@bytedance.com,
	punit.agrawal@bytedance.com, simon.evans@bytedance.com,
	liangma@liangbit.com, gpiccoli@igalia.com
Subject: Re: [PATCH v15 09/12] x86/smpboot: Support parallel startup of secondary CPUs
Date: Tue, 21 Mar 2023 17:02:27 -0400	[thread overview]
Message-ID: <CAMzpN2ijBZV0d+FjXpi8iP9rQ2gFgQ-9TtkZMB4xDizox1yW3g@mail.gmail.com> (raw)
In-Reply-To: <30efad7b8a5922cdaa48ab89a2dbaf425daf49a8.camel@infradead.org>

On Tue, Mar 21, 2023 at 3:12 PM David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Tue, 2023-03-21 at 14:28 -0400, Brian Gerst wrote:
> >
> > > @@ -264,6 +318,14 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
> > >          lgdt    (%rsp)
> > >          addq    $16, %rsp
> > >
> > > +       /* Drop the realmode protection. For the boot CPU the pointer is NULL! */
> > > +       movq    trampoline_lock(%rip), %rax
> > > +       testq   %rax, %rax
> > > +       jz      .Lsetup_data_segments
> > > +       lock
> > > +       btrl    $0, (%rax)
> > > +
> > > +.Lsetup_data_segments:
> > >          /* set up data segments */
> > >          xorl %eax,%eax
> > >          movl %eax,%ds
> >
> > This can still go earlier, right after "movq TASK_threadsp(%rax),
> > %rsp".  The GDT descriptor is placed on the idle thread stack, so it's
> > safe to drop the lock before it.
>
>
> --- a/arch/x86/kernel/head_64.S
> +++ b/arch/x86/kernel/head_64.S
> @@ -335,6 +335,17 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
>         movq    pcpu_hot + X86_current_task(%rdx), %rax
>         movq    TASK_threadsp(%rax), %rsp
>
> +       /*
> +        * Now that this CPU is running on its own stack, drop the realmode
> +        * protection. For the boot CPU the pointer is NULL!
> +        */
> +       movq    trampoline_lock(%rip), %rax
> +       testq   %rax, %rax
> +       jz      .Lsetup_gdt
> +       lock
> +       btrl    $0, (%rax)
> +
> +.Lsetup_gdt:
>         /*
>          * We must switch to a new descriptor in kernel space for the GDT
>          * because soon the kernel won't have access anymore to the userspace
> @@ -377,14 +388,6 @@ SYM_INNER_LABEL(secondary_startup_64_no_verify, SYM_L_GLOBAL)
>         shrq    $32, %rdx
>         wrmsr
>
> -       /* Drop the realmode protection. For the boot CPU the pointer is NULL! */
> -       movq    trampoline_lock(%rip), %rax
> -       testq   %rax, %rax
> -       jz      .Lsetup_idt
> -       lock
> -       btrl    $0, (%rax)
> -
> -.Lsetup_idt:
>         /* Setup and Load IDT */
>         pushq   %rsi
>         call    early_setup_idt
>

Looks good, thanks.

  reply	other threads:[~2023-03-21 21:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 22:20 [PATCH v15 00/12] Parallel CPU bringup for x86_64 Usama Arif
2023-03-16 22:20 ` [PATCH v15 01/12] x86/apic/x2apic: Allow CPU cluster_mask to be populated in parallel Usama Arif
2023-03-21 14:14   ` [tip: x86/apic] " tip-bot2 for David Woodhouse
2023-03-16 22:20 ` [PATCH v15 02/12] cpu/hotplug: Move idle_thread_get() to <linux/smpboot.h> Usama Arif
2023-03-19 16:34   ` Borislav Petkov
2023-03-20  8:17     ` David Woodhouse
2023-03-21 19:20       ` David Woodhouse
2023-03-16 22:21 ` [PATCH v15 03/12] cpu/hotplug: Add dynamic parallel bringup states before CPUHP_BRINGUP_CPU Usama Arif
2023-03-20 14:30   ` Thomas Gleixner
2023-03-21 19:14     ` David Woodhouse
2023-03-16 22:21 ` [PATCH v15 04/12] x86/smpboot: Reference count on smpboot_setup_warm_reset_vector() Usama Arif
2023-03-21 11:41   ` Borislav Petkov
2023-03-21 11:43     ` David Woodhouse
2023-03-21 14:14   ` [tip: x86/apic] " tip-bot2 for David Woodhouse
2023-03-16 22:21 ` [PATCH v15 05/12] x86/smpboot: Split up native_cpu_up into separate phases and document them Usama Arif
2023-03-16 22:21 ` [PATCH v15 06/12] x86/smpboot: Remove initial_stack on 64-bit Usama Arif
2023-03-21 14:14   ` [tip: x86/apic] " tip-bot2 for Brian Gerst
2023-03-16 22:21 ` [PATCH v15 07/12] x86/smpboot: Remove early_gdt_descr " Usama Arif
2023-03-21 14:14   ` [tip: x86/apic] " tip-bot2 for Brian Gerst
2023-03-16 22:21 ` [PATCH v15 08/12] x86/smpboot: Remove initial_gs Usama Arif
2023-03-21 14:14   ` [tip: x86/apic] " tip-bot2 for Brian Gerst
2023-03-16 22:21 ` [PATCH v15 09/12] x86/smpboot: Support parallel startup of secondary CPUs Usama Arif
2023-03-21 18:28   ` Brian Gerst
2023-03-21 19:12     ` David Woodhouse
2023-03-21 21:02       ` Brian Gerst [this message]
2023-03-16 22:21 ` [PATCH v15 10/12] x86/smpboot: Send INIT/SIPI/SIPI to secondary CPUs in parallel Usama Arif
2023-03-16 22:21 ` [PATCH v15 11/12] x86/smpboot: Serialize topology updates for secondary bringup Usama Arif
2023-03-16 22:21 ` [PATCH v15 12/12] x86/smpboot: Allow parallel bringup for SEV-ES Usama Arif
2023-03-17 16:04   ` Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMzpN2ijBZV0d+FjXpi8iP9rQ2gFgQ-9TtkZMB4xDizox1yW3g@mail.gmail.com \
    --to=brgerst@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=fam.zheng@bytedance.com \
    --cc=gpiccoli@igalia.com \
    --cc=hewenliang4@huawei.com \
    --cc=hpa@zytor.com \
    --cc=kim.phillips@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=liangma@liangbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mimoja@mimoja.de \
    --cc=mingo@redhat.com \
    --cc=oleksandr@natalenko.name \
    --cc=paulmck@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=piotrgorski@cachyos.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=punit.agrawal@bytedance.com \
    --cc=rcu@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=simon.evans@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=usama.arif@bytedance.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).