From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] HID: multitouch: remove usbhid dependency
Date: Mon, 25 Feb 2013 11:18:58 +0100 [thread overview]
Message-ID: <CAN+gG=G5QpJxiVRBaU1Z9UeSAoTiezcPyCrvC2jyzopzhFnXqA@mail.gmail.com> (raw)
In-Reply-To: <20130220202531.GA1413@polaris.bitmath.org>
Hi Henrik,
On Wed, Feb 20, 2013 at 9:25 PM, Henrik Rydberg <rydberg@euromail.se> wrote:
> Hi Benjamin,
>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
>> ---
>> drivers/hid/hid-multitouch.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Since removing the transport layer dependency has a rationale, it
> might be good to mention that here.
Ok, will do.
>
> Also, what about the explicit usb dependency, was that going to be
> moved to a usbhid quirk?
Currently, the USB dependency is protected by a check on the BUS.
The problem is that the BUS can be faked (by uhid). So yes, I'll add a
quirk under usbhid for those devices.
Cheers,
Benjamin
>
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 32258ba..184ac0a 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -32,7 +32,6 @@
>> #include <linux/slab.h>
>> #include <linux/usb.h>
>> #include <linux/input/mt.h>
>> -#include "usbhid/usbhid.h"
>>
>>
>> MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
>> @@ -907,7 +906,7 @@ static int mt_resume(struct hid_device *hdev)
>>
>> intf = to_usb_interface(hdev->dev.parent);
>> interface = intf->cur_altsetting;
>> - dev = hid_to_usb_dev(hdev);
>> + dev = interface_to_usbdev(intf);
>>
>> /* Some Elan legacy devices require SET_IDLE to be set on resume.
>> * It should be safe to send it to other devices too.
>> --
>> 1.8.1
>>
>
> Thanks,
> Henrik
next prev parent reply other threads:[~2013-02-25 10:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 14:37 [PATCH 0/7] hid driver transport cleanup Benjamin Tissoires
2013-02-08 14:37 ` [PATCH 1/7] HID: Extend the interface with report requests Benjamin Tissoires
2013-02-15 19:46 ` Henrik Rydberg
2013-02-08 14:37 ` [PATCH 2/7] HID: Extend the interface with wait io request Benjamin Tissoires
2013-02-15 20:47 ` Henrik Rydberg
2013-02-08 14:37 ` [PATCH 3/7] HID: Kconfig: Remove explicit transport layer dependencies Benjamin Tissoires
2013-02-20 20:06 ` Henrik Rydberg
2013-02-25 10:15 ` Benjamin Tissoires
2013-02-08 14:37 ` [PATCH 4/7] hid: use hid_hw_request() instead of direct call to usbhid Benjamin Tissoires
2013-02-20 20:16 ` Henrik Rydberg
2013-02-08 14:37 ` [PATCH 5/7] HID: use hid_hw_wait() " Benjamin Tissoires
2013-02-20 20:18 ` Henrik Rydberg
2013-02-08 14:37 ` [PATCH 6/7] HID: multitouch: remove usbhid dependency Benjamin Tissoires
2013-02-20 20:25 ` Henrik Rydberg
2013-02-25 10:18 ` Benjamin Tissoires [this message]
2013-02-08 14:37 ` [PATCH 7/7] HID: multitouch: Copyright and note on regression tests Benjamin Tissoires
2013-02-20 20:26 ` Henrik Rydberg
2013-02-11 10:13 ` [PATCH 0/7] hid driver transport cleanup Mika Westerberg
2013-02-11 11:19 ` Benjamin Tissoires
2013-02-11 11:29 ` Mika Westerberg
2013-02-18 9:13 ` Jiri Kosina
2013-02-18 20:49 ` Henrik Rydberg
2013-02-20 20:31 ` Henrik Rydberg
2013-02-25 10:20 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN+gG=G5QpJxiVRBaU1Z9UeSAoTiezcPyCrvC2jyzopzhFnXqA@mail.gmail.com' \
--to=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).