From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965258AbbCPOqf (ORCPT ); Mon, 16 Mar 2015 10:46:35 -0400 Received: from mail-qg0-f44.google.com ([209.85.192.44]:33129 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933838AbbCPOq3 (ORCPT ); Mon, 16 Mar 2015 10:46:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1423253075-23469-1-git-send-email-benjamin.tissoires@redhat.com> <54EDE30C.3080208@redhat.com> <20150309064649.GE17331@dtor-ws> <54FD58B0.7060003@redhat.com> Date: Mon, 16 Mar 2015 10:46:28 -0400 Message-ID: Subject: Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time! From: Benjamin Tissoires To: Hans de Goede , Daniel Martin Cc: Dmitry Torokhov , Andrew Duggan , Peter Hutterer , linux-input , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 9, 2015 at 3:36 PM, Benjamin Tissoires wrote: > On Mon, Mar 9, 2015 at 4:24 AM, Hans de Goede wrote: >> Hi, >> >> >> On 09-03-15 07:46, Dmitry Torokhov wrote: >>> >>> On Wed, Feb 25, 2015 at 03:58:20PM +0100, Hans de Goede wrote: >>>> >>>> Hi, >>>> >>>> On 25-02-15 15:36, Benjamin Tissoires wrote: >>>>> >>>>> On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tissoires >>>>> wrote: >>>>>> >>>>>> On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires >>>>>> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> This is the second episode of the Lenovo 2015 party :) >>>>>>> >>>>>>> Thanks to Andrew, we now have an idea within the driver of what are >>>>>>> the extra >>>>>>> buttons aimed for, and the patch series looks cleaner. >>>>>>> Many thanks for your help. >>>>>>> >>>>>>> I marked only patches 1/7, 2/7 and 3/7 as stable because they are >>>>>>> really >>>>>>> stable fixes. Without the rest of the series, user-space can cope with >>>>>>> the >>>>>>> kernel result, and so there is IMO no need to backport too many >>>>>>> patches in >>>>>>> stable. I bet distributions will cherry-pick the rest of the series >>>>>>> however. >>>>>>> >>>>>> >>>>>> Guys, >>>>>> >>>>>> any chances we consider this for 3.20 (or whatever it will be >>>>>> numbered)? >>>>>> I'd really like to see this accepted upstream in one way or one other >>>>>> so we will prevent the mess we had to deal with last year. >>>>>> >>>>> >>>>> Hans, Dmitry, >>>>> >>>>> well, it's been 3 weeks since I received the loaner I have to support >>>>> these touchpads. I will have to return it next week or the week after >>>>> at most. That means that I will not be able to conduct more tests at >>>>> that point. >>>>> Can I ask you to please review the series? >>>> >>>> >>>> Ah, sorry I missed you did a v2 (I did review v1). >>>> >>>> Series looks good to me and is: >>>> >>>> Acked-by: Hans de Goede >>> >>> >>> I did a few edits of the patches in the 2 series so I created a separate >>> branch "synaptics" based on 3.19. I'd appreciate if you could give it q >>> quick spin before I will send it for 4.0. >> >> >> I don't have access to the hardware in question, but Benjamin does, so >> we'll have to wait (a bit) for him to wake up :) >> > > It took me a little bit of time to retrieve the laptop and get it tested. > So far, so good: > - t440s (2013) shows the correct behavior > - x1 carbon 3 has the buttons properly forwarded through the > trackstick interface and are reacting as expected. > > Thanks Dmitry! > > I've added Daniel to the thread and asked it this morning if he could > also give a try to the series. > It's been a week since this testing request has been made. So far: - we pushed that on Fedora 22/rawhide since last Thu, no bad reports since - our internal IT tested the series on a X250 and W541 with good results - I recieved other reports from X250 IIRC, no problems so far I guess it's time to merge this branch in your "next" branch at least. Cheers, Benjamin