From: "Martin Ågren" <martin.agren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
git-packagers@googlegroups.com
Subject: Re: [ANNOUNCE] Git v2.29.0-rc0
Date: Tue, 6 Oct 2020 05:57:02 +0200 [thread overview]
Message-ID: <CAN0heSrKgNSHKDL07-BWrbF9n6fyWUZVDykdHPCD6CfwgV8QNA@mail.gmail.com> (raw)
In-Reply-To: <xmqqa6x070tn.fsf@gitster.c.googlers.com>
Hi Junio,
Thanks for the release candidate!
Minor comments follow.
On Tue, 6 Oct 2020 at 01:00, Junio C Hamano <gitster@pobox.com> wrote:
> * The final leg of SHA-256 transition plus doc updates. Note that
> there is no inter-operability between SHA-1 and SHA-256
> repositories yet.
I suspect the dash in "inter-operability" should be dropped.
> * Various callers of run_command API has been modernized.
> (merge afbdba391e jc/run-command-use-embedded-args later to maint).
s/has/have/
> * List of options offered and accepted by "git add -i/-p" were
> inconsistent, which have been corrected.
> (merge ce910287e7 pw/add-p-allowed-options-fix later to maint).
>
> * Various callers of run_command API has been modernized.
> (merge afbdba391e jc/run-command-use-embedded-args later to maint).
Here's that entry again from my previous comment.
> * "git status" has trouble showing where it came from by interpreting
> reflog entries that record certain events, e.g. "checkout @{u}", and
> gives a hard/fatal error. Even though it inherently is impossible
> to give a correct answer because the reflog entries lose some
> information (e.g. "@{u}" does not record what branch the user was
> on hence which branch 'the upstream' needs to be computed, and even
> if the record were available, the relationship between branches may
> have changed), at least hide the error to allow "status" show its
> output.
s/show/to &/ ?
> * There is a logic to estimate how many objects are in the
> repository, which is mean to run once per process invocation, but
s/mean/meant/, I think.
> * The "unshelve" subcommand of "git p4" used incorrectly used
s/used // (without 'g' flag!)
Martin
next prev parent reply other threads:[~2020-10-06 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 22:41 [ANNOUNCE] Git v2.29.0-rc0 Junio C Hamano
2020-10-05 23:33 ` Bryan Turner
2020-10-05 23:42 ` Randall S. Becker
2020-10-06 3:57 ` Martin Ågren [this message]
2020-10-06 6:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSrKgNSHKDL07-BWrbF9n6fyWUZVDykdHPCD6CfwgV8QNA@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).