From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22304C433DF for ; Tue, 13 Oct 2020 09:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C50205CA for ; Tue, 13 Oct 2020 09:58:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bkz9pVt/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727346AbgJMJ6Y (ORCPT ); Tue, 13 Oct 2020 05:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgJMJ6X (ORCPT ); Tue, 13 Oct 2020 05:58:23 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5FBAC0613D0 for ; Tue, 13 Oct 2020 02:58:21 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id t25so27329954ejd.13 for ; Tue, 13 Oct 2020 02:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KGj66PymmEXKJDO8ZEQ4dV/3pOkqQJIBTnNRKT6VgnY=; b=bkz9pVt/0z+6dp1a45Sgz7q83y4GHjYjVZhpv2WKPWEYPmb24hIdDf16oLqAnAwJbn vAnF5NqAZTuRH7eZrjJWn1T6wFZMZZRYKpmVvxjuvTPexuVaeGcWuuQA4/YA9vSoIPLd SR9hYd10h2SpjvcW8Mer/uBGf/WK04xHYQsuLqUOYem8IvVQkDJN73he9Nv/jC9ugPGF caT3S8AJxGaKSagF8gkGlG6YxDql7TfEVtePtOlQdEvhc5zUYya870b9o2R6J3eQFwKk eP2xZDm70a7T8MtAjHOaCq2XuN1doxHK0q5NG++LQSsYP8C9eBEfXUyVTR/NIp8iMFkD 1MiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KGj66PymmEXKJDO8ZEQ4dV/3pOkqQJIBTnNRKT6VgnY=; b=sKBrk02HgTlSg5VnPRGu0hY0Myum5aM1AQ5305u07ygiCvrHmX24akES+UE9JNcyPN +NNHWG8pPOuVQ4fK7p44XZNF0ESBqtIgBkFE1wo0cmjGLbG/WxXK/X3nutKocRA38afL Bt03/1H57OTeQ8bIKVqBuNJ0LftrnXUUqdDd2asJ6jxclTbp+TGepNDSbwMvDkU3E910 pFHDxZMw97vCak6ad0nTQyA7HIIuwErHvzlgeuG6xn9E9kRMMLLGqh2rwrsI3D0V0gkx r8Rz38islkqxYJyS12HQkfPEUzNt7py395qwwjCKxa1tqv12ChlG7Skp7IJFVPpeTag3 VLXQ== X-Gm-Message-State: AOAM533pJ84Hc6zH09Q28KgjD+dKjuJKuQTytM5frUtNhUICJGvbVwBK LbujZWrRDKMF+DzIr0hc2f5fNvPk19IcZNW3Dt/b+g== X-Google-Smtp-Source: ABdhPJxuiSelGlMC1dIpiF3M2m+tfmeJ5+JbgRsdpEfYjmi0ot9nyY+X9aWYIn8k7xbPH1VguxnO6JbNQFUpiAG0jiE= X-Received: by 2002:a17:906:494:: with SMTP id f20mr31928896eja.285.1602583100513; Tue, 13 Oct 2020 02:58:20 -0700 (PDT) MIME-Version: 1.0 References: <20201008143722.21888-2-etienne.carriere@linaro.org> <20201012141746.32575-1-sudeep.holla@arm.com> In-Reply-To: <20201012141746.32575-1-sudeep.holla@arm.com> From: Etienne Carriere Date: Tue, 13 Oct 2020 11:58:09 +0200 Message-ID: Subject: Re: [PATCH] firmware: arm_scmi: Add missing Rx size re-initialisation To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Cristian Marussi , Vincent Guittot , Souvik Chakravarty Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2020 at 16:17, Sudeep Holla wrote: > > Few commands provide the list of description partially and require > to be called consecutively until all the descriptors are fetched > completely. In such cases, we don't release the buffers and reuse > them for consecutive transmits. > > However, currently we don't reset the Rx size which will be set as > per the response for the last transmit. This may result in incorrect > response size being interpretted as the firmware may repond with size > greater than the one set but we read only upto the size set by previous > response. > > Let us reset the receive buffer size to max possible in such cases as > we don't know the exact size of the response. > > Fixes: b6f20ff8bd94 ("firmware: arm_scmi: add common infrastructure and support for base protocol") > Reported-by: Etienne Carriere > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_scmi/base.c | 2 ++ > drivers/firmware/arm_scmi/clock.c | 2 ++ > drivers/firmware/arm_scmi/common.h | 8 ++++++++ > drivers/firmware/arm_scmi/perf.c | 2 ++ > drivers/firmware/arm_scmi/sensors.c | 2 ++ > 5 files changed, 16 insertions(+) > > Hi Etienne, > > I reworked this in a different way and hence dropped your authorship and added > reported by. If you prefer I can attribute you as author. I want to push > 2,4,5/5 as fixes and hence the rush. Hi Sudeep, Tags are fine like that. As for the content, it looks good to me. When trying to apply this, I failed, but I guess I'm not testing over the same kernel tree/branch as you. All in one, I am really fine with this change, I think it does the job Regards, Etienne > > Regards, > Sudeep > > diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c > index 9853bd3c4d45..017e5d8bd869 100644 > --- a/drivers/firmware/arm_scmi/base.c > +++ b/drivers/firmware/arm_scmi/base.c > @@ -197,6 +197,8 @@ static int scmi_base_implementation_list_get(const struct scmi_handle *handle, > protocols_imp[tot_num_ret + loop] = *(list + loop); > > tot_num_ret += loop_num_ret; > + > + scmi_reset_rx_to_maxsz(handle, t); > } while (loop_num_ret); > > scmi_xfer_put(handle, t); > diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c > index c1cfe3ee3d55..4645677d86f1 100644 > --- a/drivers/firmware/arm_scmi/clock.c > +++ b/drivers/firmware/arm_scmi/clock.c > @@ -192,6 +192,8 @@ scmi_clock_describe_rates_get(const struct scmi_handle *handle, u32 clk_id, > } > > tot_rate_cnt += num_returned; > + > + scmi_reset_rx_to_maxsz(handle, t); > /* > * check for both returned and remaining to avoid infinite > * loop due to buggy firmware > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 37fb583f1bf5..a3f1bc44b1de 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -245,6 +245,14 @@ extern const struct scmi_desc scmi_mailbox_desc; > extern const struct scmi_desc scmi_smc_desc; > #endif > > +static inline void scmi_reset_rx_to_maxsz(const struct scmi_handle *handle, > + struct scmi_xfer *xfer) > +{ > + struct scmi_info *info = handle_to_scmi_info(handle); > + > + xfer->rx.len = info->desc->max_msg_size; > +} > + > void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr); > void scmi_free_channel(struct scmi_chan_info *cinfo, struct idr *idr, int id); > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index ed475b40bd08..82fb3babff72 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -304,6 +304,8 @@ scmi_perf_describe_levels_get(const struct scmi_handle *handle, u32 domain, > } > > tot_opp_cnt += num_returned; > + > + scmi_reset_rx_to_maxsz(handle, t); > /* > * check for both returned and remaining to avoid infinite > * loop due to buggy firmware > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index 9703cf6356a0..b4232d611033 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -166,6 +166,8 @@ static int scmi_sensor_description_get(const struct scmi_handle *handle, > } > > desc_index += num_returned; > + > + scmi_reset_rx_to_maxsz(handle, t); > /* > * check for both returned and remaining to avoid infinite > * loop due to buggy firmware > -- > 2.17.1 >