Re: [PATCH 1/2] PCI: dwc: Add API support to de-initialize host

From: vidya sagar <sagar.tv@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>,
	jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	lorenzo.pieralisi@arm.com, bhelgaas@google.com,
	Jisheng.Zhang@synaptics.com, thierry.reding@gmail.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	kthota@nvidia.com, NManikanta <mmaddireddy@nvidia.com>
Subject: Re: [PATCH 1/2] PCI: dwc: Add API support to de-initialize host
Date: Tue, 16 Apr 2019 16:51:33 +0530	[thread overview]
Message-ID: <CAN7O0+LrM8pdSZaVpy-G1BZJUQPSPKPrfBBBm5WiEN8+XJGn8A@mail.gmail.com> (raw)
In-Reply-To: <1554380425-29215-2-git-send-email-vidyas@nvidia.com>

Anyone for the review of this patch series (total 2 patches)?

On Thu, Apr 4, 2019 at 5:50 PM Vidya Sagar <vidyas@nvidia.com> wrote:
>
> Add an API to group all the tasks to be done to de-initialize host which
> can then be called by any Designware core based driver implementations
> while adding .remove() support in their respective drivers.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 7 +++++++
>  drivers/pci/controller/dwc/pcie-designware.h      | 5 +++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 3e4169e738a5..d7881490282d 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -516,6 +516,13 @@ int dw_pcie_host_init(struct pcie_port *pp)
>         return ret;
>  }
>
> +void dw_pcie_host_deinit(struct pcie_port *pp)
> +{
> +       pci_stop_root_bus(pp->root_bus);
> +       pci_remove_root_bus(pp->root_bus);
> +       dw_pcie_free_msi(pp);
> +}
> +
>  static int dw_pcie_access_other_conf(struct pcie_port *pp, struct pci_bus *bus,
>                                      u32 devfn, int where, int size, u32 *val,
>                                      bool write)
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index adff0c713665..ea8d1caf11c5 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -343,6 +343,7 @@ void dw_pcie_msi_init(struct pcie_port *pp);
>  void dw_pcie_free_msi(struct pcie_port *pp);
>  void dw_pcie_setup_rc(struct pcie_port *pp);
>  int dw_pcie_host_init(struct pcie_port *pp);
> +void dw_pcie_host_deinit(struct pcie_port *pp);
>  int dw_pcie_allocate_domains(struct pcie_port *pp);
>  #else
>  static inline irqreturn_t dw_handle_msi_irq(struct pcie_port *pp)
> @@ -367,6 +368,10 @@ static inline int dw_pcie_host_init(struct pcie_port *pp)
>         return 0;
>  }
>
> +static inline void dw_pcie_host_deinit(struct pcie_port *pp)
> +{
> +}
> +
>  static inline int dw_pcie_allocate_domains(struct pcie_port *pp)
>  {
>         return 0;
> --
> 2.7.4
>