linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tri Vo <trong@android.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: Greg Hackmann <ghackmann@android.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-team@android.com,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 0/3] gcov: add Clang support
Date: Mon, 11 Mar 2019 21:57:42 -0700	[thread overview]
Message-ID: <CANA+-vCPOSWq5o6c3kT=jdLmyyJW9P9_-ZORPus6aFbFoBNUkA@mail.gmail.com> (raw)
In-Reply-To: <7c7b4521-d747-d064-0506-4e3d6746877e@linux.ibm.com>

On Tue, Mar 5, 2019 at 6:29 AM Peter Oberparleiter
<oberpar@linux.ibm.com> wrote:
>
> On 23.01.2019 00:37, Tri Vo wrote:
> > This patch series adds Clang supoprt for gcov.
> >
> > Patch 1 refactors existing code in preparation for Clang support.
> > Patch 2 implements necessary LLVM runtime hooks and gcov kernel interfaces.
> > Patch 3 updates documentation.
>
> Thanks for the updates! I've provided suggestions for some minor
> improvements in my other review e-mails.
>
> With those changes applied, the patch set is in my opinion ready for
> inclusion into the mainline kernel. My suggestion would be to re-post
> the resulting version while putting Andrew Morton on CC as gcov changes
> are typically integrated via his tree.
>
> Also I've successfully re-tested this patch set version on s390 using
> GCC 7.3.0 to ensure that the existing GCC support is still working.
> Unfortunately I wasn't able to test the Clang version due to some
> compile problems on s390 (unrelated to this patch set).
>
> If you haven't done so, I would like to suggest to run the following
> tests with the Clang gcov-kernel version that should catch problems in
> some corner cases:
>
> 1. Unload a module, then use llvm-cov on the associated coverage file.
>
>    Expectation: correct llvm-cov output including coverage of module
>    exit code.
>
> 2. Unload a module, modify its source, re-compile it and load it again,
>    then use llvm-cov on the associated coverage file.
>
>    Expectation: kernel message "discarding saved data", correct llvm-cov
>    output with no coverage of module exit code.
>
> 3. Unload a module, then reset all coverage data by writing to
>    /sys/kernel/debug/gcov/reset.
>
>    Expectation: all coverage files associated with the module are
>    removed from debugfs.

Thanks for the suggested test cases! The current patchset doesn't seem
to handle module loading/unloading correctly. I'll fix that in a
follow-up.

      reply	other threads:[~2019-03-12  4:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 23:37 [PATCH v3 0/3] gcov: add Clang support Tri Vo
2019-01-22 23:37 ` [PATCH v3 1/3] gcov: Clang: move common GCC code into gcc_base.c Tri Vo
2019-03-05 13:40   ` Peter Oberparleiter
2019-01-22 23:37 ` [PATCH v3 2/3] gcov: Clang support Tri Vo
2019-03-05 13:57   ` Peter Oberparleiter
2019-01-22 23:37 ` [PATCH v3 3/3] gcov: docs: add a note on GCC vs Clang differences Tri Vo
2019-01-22 23:50   ` Nick Desaulniers
2019-03-05 14:07   ` Peter Oberparleiter
2019-02-07  0:52 ` [PATCH v3 0/3] gcov: add Clang support Nick Desaulniers
2019-02-22  0:57   ` Nick Desaulniers
2019-03-05 14:29 ` Peter Oberparleiter
2019-03-12  4:57   ` Tri Vo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANA+-vCPOSWq5o6c3kT=jdLmyyJW9P9_-ZORPus6aFbFoBNUkA@mail.gmail.com' \
    --to=trong@android.com \
    --cc=akpm@linux-foundation.org \
    --cc=ghackmann@android.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=oberpar@linux.ibm.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).