From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AE58C19425 for ; Wed, 9 Dec 2020 15:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA17923AFE for ; Wed, 9 Dec 2020 15:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbgLIPY5 (ORCPT ); Wed, 9 Dec 2020 10:24:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:38854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729897AbgLIPYw (ORCPT ); Wed, 9 Dec 2020 10:24:52 -0500 X-Gm-Message-State: AOAM531SoFAYLQnj0jennEk6voaj32kgYbGkQUaGfVBulDg/ccnRAPmU COK51Dy0XrGZZ50BagMD9cJf3H9wGbYgG+1TEB5hMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607527452; bh=+dXI+bpx4dnaTYf5igVjStgYvCfJ0BEDZGFbpTVmtxE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eL3C/FLF45GyK9oe47qbVFU4xEUNTzBuEf8biAee4dVkAAQcasA7yOP8rFNyZyE/n sv9eHOn4s29Njzd1V6Knxfosb3MCAEyU+5qTUgQZgCj4EX3TkkQsRnLzhlu+26/4pH 76c2IWFC8ek+1rPK/i5yIWKwbUP5vQl0REQvoL1rNRj3NK+hv+Wbm1zaWMyvu2No3R kh4dU/CNJaCLs/zQuwndHNL1JiSX+U+dO+9289EFxCv/QyOU+XEi+T4e/WwoZWU4W8 H0XsT8z67p8dQ9jkjR2RIcOUujrhPzbtukFbabYkptZGLuPtrG2/fbk+aHhEBfviFc V4mKqErlYSaHQ== X-Google-Smtp-Source: ABdhPJzO1xxGSE3TeUyPtZqx87VH61OUOrOKxLclNwlNTe1YN6+iqHWrVur5Iq75ZqI8mPoMOcm3CWtxazp2WuPxwSg= X-Received: by 2002:a19:8343:: with SMTP id f64mr1192727lfd.542.1607527450100; Wed, 09 Dec 2020 07:24:10 -0800 (PST) MIME-Version: 1.0 References: <20201209132636.1545761-1-revest@chromium.org> <20201209132636.1545761-2-revest@chromium.org> In-Reply-To: <20201209132636.1545761-2-revest@chromium.org> From: KP Singh Date: Wed, 9 Dec 2020 16:23:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v4 2/4] bpf: Expose bpf_get_socket_cookie to tracing programs To: Florent Revest Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@chromium.org, Martin KaFai Lau , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 9, 2020 at 2:29 PM Florent Revest wrote: > > This needs two new helpers, one that works in a sleepable context (using > sock_gen_cookie which disables/enables preemption) and one that does not > (for performance reasons). Both take a struct sock pointer and need to > check it for NULLness. > > This helper could also be useful to other BPF program types such as LSM. > > Signed-off-by: Florent Revest Acked-by: KP Singh