Re: [PATCH 3/3] ARM: dts: meson8b: odroidc1: enable the SDHC controller

From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org,
	Kevin Hilman <khilman@baylibre.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: dts: meson8b: odroidc1: enable the SDHC controller
Date: Mon, 22 Jun 2020 18:17:10 +0530	[thread overview]
Message-ID: <CANAwSgQC_sf2Hvuf29aeSttF5JmJqBoXLOa=HybFys_hmBns3g@mail.gmail.com> (raw)
In-Reply-To: <20200620163654.37207-4-martin.blumenstingl@googlemail.com>

Hi Martin,

On Sat, 20 Jun 2020 at 22:08, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Odroid-C1 has an eMMC connector where users can optionally install an
> eMMC module. The eMMC modules run off a 1.8V VQMMC supply which means
> that HS-200 mode can be used (this is the highest mode that the SDHC
> controller supports). Enable the SDHC controller so eMMC modules can be
> accessed.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Please add my
Reviewed-by: Anand Moon <linux.amoon@gmail.com>

-Anand
> ---
>  arch/arm/boot/dts/meson8b-odroidc1.dts | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index cb21ac9f517c..0c26467de4d0 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -15,6 +15,7 @@ / {
>         aliases {
>                 serial0 = &uart_AO;
>                 mmc0 = &sd_card_slot;
> +               mmc1 = &sdhc;
>         };
>
>         chosen {
> @@ -26,6 +27,11 @@ memory {
>                 reg = <0x40000000 0x40000000>;
>         };
>
> +       emmc_pwrseq: emmc-pwrseq {
> +               compatible = "mmc-pwrseq-emmc";
> +               reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;
> +       };
> +
>         leds {
>                 compatible = "gpio-leds";
>                 blue {
> @@ -310,6 +316,26 @@ &saradc {
>         vref-supply = <&vcc_1v8>;
>  };
>
> +&sdhc {
> +       status = "okay";
> +
> +       pinctrl-0 = <&sdxc_c_pins>;
> +       pinctrl-names = "default";
> +
> +       bus-width = <8>;
> +       max-frequency = <100000000>;
> +
> +       disable-wp;
> +       cap-mmc-highspeed;
> +       mmc-hs200-1_8v;
> +       no-sdio;
> +
> +       mmc-pwrseq = <&emmc_pwrseq>;
> +
> +       vmmc-supply = <&vcc_3v3>;
> +       vqmmc-supply = <&vcc_1v8>;
> +};
> +
>  &sdio {
>         status = "okay";
>
> --
> 2.27.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic