From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FDBC47404 for ; Mon, 7 Oct 2019 15:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF6120679 for ; Mon, 7 Oct 2019 15:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIm5xSbR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbfJGPyH (ORCPT ); Mon, 7 Oct 2019 11:54:07 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:39272 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbfJGPyG (ORCPT ); Mon, 7 Oct 2019 11:54:06 -0400 Received: by mail-io1-f67.google.com with SMTP id a1so29693444ioc.6; Mon, 07 Oct 2019 08:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=GIm5xSbRI50sJepzUbwycg7NDvMt3BT+3RYQ1Ak3PHk03MA/wlw9SqTNGY2DfIZkI3 vzloLLiQdo1Im+2BoTX2drQ9SytWBxd+eHhHN+oxkN83GrWLEW2lR8fnp2/7fI3yPVJk ZxOm4F1VeDXgpPbLMuAjDt3XlVRxikDPzHve8KYJuOw5hyLbMGGgxDCmn4YkVI3ivd7q +qC9HjO+buQM/o2qZs44GNytFS6dr+QBe4nE9YfUXJ9tYuB3aUliVkTo2PYIw168NusB jYzgE62kDvg5lylYW9+xxyGY9aRNG6dfE/sjjE4tsJNb9Fkc+4mHngnT1fhm2fIWSs2U RT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=TT0iZBLI16XwtTexmqZsUD5xmgKK/gzd0xMCjNNoM/VB5dn7LIR8A102KgkWh3HJmf iYXdlqA3pr1R5OFeFHb4/6YH9gnN1uy7yWAzamyPLdGxlpTdYj2Rtly7Uwbh76BQW4dt JPylGWhsS0F5bVYi2fJTjKPhrfmNGBW9UoBanU3rqcyOWUifJ1jO2dPIK0NDfCo0QmS2 WLrL2eahRMCWWkWVmlNLjhMMwFi2mrT6MOf6xk/sYUuoQvh8/u1wdAy25IcY20iDFZcJ xHzaHZX5U7ahJlbLEiZsAT8sZgHfo834Blgwbj60BKOksT/qeRCqZTdnfze/24bcqfdK Jh0Q== X-Gm-Message-State: APjAAAWe6WD8WI9jHmDQffAgaK7+MzyQxegubfwqQETzGc6ULP/5udX4 WjvDFKneRUinhIk+Q25EVexhTL9qbTmgi60cU/A= X-Google-Smtp-Source: APXvYqw9T09ClSC4idvRRaaJZz/xKErgE5SB3WxVYBhzuMFYdqY2HrLZiaXgYCS9faKiSyduxgwe6sfmi9HXu2ybLSY= X-Received: by 2002:a02:c983:: with SMTP id b3mr27831643jap.120.1570463645906; Mon, 07 Oct 2019 08:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-4-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 21:23:53 +0530 Message-ID: Subject: Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD To: Neil Armstrong Cc: Rob Herring , Mark Rutland , Kevin Hilman , Martin Blumenstingl , Jerome Brunet , Catalin Marinas , Will Deacon , devicetree , linux-arm-kernel , linux-amlogic@lists.infradead.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Mon, 7 Oct 2019 at 19:51, Neil Armstrong wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD > > regulator. Also add TFLASH_VDD_EN signal name to gpio pin. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 66262a6ab3fe..6bd23a1e7e1d 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -51,9 +51,12 @@ > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* TFLASH_VDD_EN */ > > gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > + /* U18 FC8731-09VF05NRR */ > > + vin-supply = <&vddao_3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > > > Reviewed-by: Neil Armstrong Thanks, Best Regards -Anand