linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Andreas Mohr <andi@lisas.de>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition
Date: Tue, 7 Apr 2015 13:32:33 +0600	[thread overview]
Message-ID: <CANCZXo7SDXMvgnnMPfXFr3p8GtBCw9kENeOKXe78JB=kpHjpiw@mail.gmail.com> (raw)
In-Reply-To: <20150406193509.GA4476@rhlx01.hs-esslingen.de>

Hello Andreas,

>
> IMHO explicitly #include:ing parts
> which certain code does actively depend on after all
> is both a "code honesty"
> and a documentation issue ("Hmm, which interfaces does this implementation
> depend on? Ah, yeah...")
>

Yes, before the patch i was in hesitancy, how to be with 'includes'.
To add linux/compiler.h
to the boot.h or do not do it as it already in the bitops.h. That's
why I have added note
about in to the commit message, for getting feedback about this.

Thank you.

  reply	other threads:[~2015-04-07  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06  9:04 [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition Alexander Kuleshov
2015-04-06 19:35 ` Andreas Mohr
2015-04-07  7:32   ` Alexander Kuleshov [this message]
2015-04-07  8:35 ` Ingo Molnar
2015-04-07  8:56   ` Borislav Petkov
2015-04-07  9:17     ` Alexander Kuleshov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANCZXo7SDXMvgnnMPfXFr3p8GtBCw9kENeOKXe78JB=kpHjpiw@mail.gmail.com' \
    --to=kuleshovmail@gmail.com \
    --cc=andi@lisas.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).