From: John Stultz <jstultz@google.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Dawei Li <set_pte_at@outlook.com>,
sumit.semwal@linaro.org, benjamin.gaignard@collabora.com,
labbott@redhat.com, Brian.Starkey@arm.com, afd@ti.com,
sspatil@android.com, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()
Date: Wed, 23 Nov 2022 11:19:24 -0800 [thread overview]
Message-ID: <CANDhNCrKaa580Hb-w5GcGxo-h5xr9_GSq86JUSfR+meVLqiY1g@mail.gmail.com> (raw)
In-Reply-To: <56393e84-485b-42ba-5fce-d4a0d0017653@amd.com>
On Mon, Nov 21, 2022 at 10:24 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Hi Dawei,
>
> from the technical description, coding style etc.. it looks clean to me,
> but I'm the completely wrong person to ask for a background check.
>
> I have a high level understanding of how dma-heaps work, but not a
> single line of this code is from me.
>
> Feel free to add my Acked-by, but Laura, John and others do you have any
> opinion?
No objection from me.
Thanks Dawei for submitting this improvement!
Acked-by: John Stultz <jstultz@google.com>
thanks
-john
prev parent reply other threads:[~2022-11-23 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 16:05 [PATCH v4] dma-buf: fix racing conflict of dma_heap_add() Dawei Li
2022-11-04 16:10 ` Andrew Davis
2022-11-21 15:28 ` Dawei Li
2022-11-21 18:23 ` Christian König
2022-11-22 10:17 ` Sumit Semwal
2022-11-23 19:19 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANDhNCrKaa580Hb-w5GcGxo-h5xr9_GSq86JUSfR+meVLqiY1g@mail.gmail.com \
--to=jstultz@google.com \
--cc=Brian.Starkey@arm.com \
--cc=afd@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=set_pte_at@outlook.com \
--cc=sspatil@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).