From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B89C433E9 for ; Mon, 18 Jan 2021 22:03:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21A5422CB1 for ; Mon, 18 Jan 2021 22:03:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbhARWDT (ORCPT ); Mon, 18 Jan 2021 17:03:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387557AbhARWCz (ORCPT ); Mon, 18 Jan 2021 17:02:55 -0500 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8601C0613ED for ; Mon, 18 Jan 2021 14:02:14 -0800 (PST) Received: by mail-vs1-xe2a.google.com with SMTP id o186so2233904vso.1 for ; Mon, 18 Jan 2021 14:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cgYXXKDGBW6a/Ay3lvFyQRjl1IFnWA6SVXMh0iaCM6U=; b=eyMgvEKMYxzdZvh8xGdzUCAR5CvGMETl+M8cnoeriJLzg1OfILsdm/eOp6Oaln9s6b LqD8nFm7Hyk93ADZ6I0mplNmUXPSB1rzRSsY6lN2MnOBnviqDkrwT7cyQqoxHkWKKM+F To7ReuUilxRCUbWz4ER8OvSGYi0offyr/Audg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cgYXXKDGBW6a/Ay3lvFyQRjl1IFnWA6SVXMh0iaCM6U=; b=WerIQo+dTihzBhU7Kigg44L1jeWUp7+Zvpftyygwu/sj6kOb4djNtZ8JlnXEcHuKdw uZfgdg1ajlo0ewWq2kcx7Gb7kg1/uRRIgV+hs13ct08Y7ROl0mfRYm7EORfTfY0ayHEk iHAY2OC/tfnsZYUmAseUY+7InHarSZSmnO0Yb+yVDjtaJazYRBygT6Xy2ofr1imTfm6J LD1UvaKWX4GGq9Qg2G2E6g1JL1zbWi3tfL17L/4HTlNXgoZjeQmYMuRNV5TGMbDrL/7s txKZwA8vkh1GzcLANjA2WGBLMvshd4S9oUdpsYim6XD1Q93z7pWf3WqKMc3o8SMOsE2k PU/g== X-Gm-Message-State: AOAM530gdcDC6MPTcOSm9xiY6sjlgnWcb1novQONaXnqaQZWpy7EWqu1 kgJRXyla7Is4XMldWA+Co1nk5rE6Hsac/GfCZmFGnw== X-Google-Smtp-Source: ABdhPJw+WCZE+eqHFzYlyDXhJA7chMXL2acKBGbLe9K3xWLbgbv5eSfb0jaPF08HUSLDtSOy898Z4m5uM/9x+cJn3io= X-Received: by 2002:a67:2a46:: with SMTP id q67mr1070098vsq.40.1611007333852; Mon, 18 Jan 2021 14:02:13 -0800 (PST) MIME-Version: 1.0 References: <20210116052623.3196274-1-grundler@chromium.org> <20210116052623.3196274-2-grundler@chromium.org> In-Reply-To: <20210116052623.3196274-2-grundler@chromium.org> From: Grant Grundler Date: Mon, 18 Jan 2021 22:02:02 +0000 Message-ID: Subject: Re: [PATCH 2/3] net: usb: log errors to dmesg/syslog To: Grant Grundler , nic_swsd Cc: Oliver Neukum , "David S. Miller" , Jakub Kicinski , Greg Kroah-Hartman , linux-usb@vger.kernel.org, netdev , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > Errors in protocol should be logged when the driver aborts operations. > If the driver can carry on and "humor" the device, then emitting > the message as debug output level is fine. > > Signed-off-by: Grant Grundler > --- > drivers/net/usb/usbnet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 1447da1d5729..bc7b93399bd5 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net) > > // insist peer be connected > if (info->check_connect && (retval = info->check_connect (dev)) < 0) { > - netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval); > + netif_err(dev, ifup, dev->net, "can't open; %d\n", retval); > goto done; > } > > -- > 2.29.2 >