From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3180C77B73 for ; Wed, 24 May 2023 21:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234213AbjEXVCE (ORCPT ); Wed, 24 May 2023 17:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbjEXVB7 (ORCPT ); Wed, 24 May 2023 17:01:59 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B1EB3 for ; Wed, 24 May 2023 14:01:57 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-510e5a8704bso783a12.1 for ; Wed, 24 May 2023 14:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684962116; x=1687554116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ecRHb3a4uZb7D9V7KAm1/nNRXIsZmVIjd+RGF7WArC0=; b=Y5GLMKGFPpIlQIqkAD39okDyWwz+EMI6KjtjQk4TVsTOtaWHy4Lt7mmHTJmGhBmz/S 7Xp5+LCH0/jjszqdPtFwYFtRNcaNAmMyWgsMV8z+snOmyhRqZ/RFPxUc/O05u+Wt8z27 wkUu4Mkt1sKkoHYscyuLFbyJzwHe3LU0BW2Ks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684962116; x=1687554116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ecRHb3a4uZb7D9V7KAm1/nNRXIsZmVIjd+RGF7WArC0=; b=P3V6CjQLl3Wrp2xrR7yqXrW3+cewOTvGEJ0+H/rXIb5fkm3ez3TS2q4mXy60QZ9zlj rAcdCD/4kTvDPq60MZkg8HrpsCMzIruNuSMufZuQYP43i6QNidFYvXs5of+sl2WUJx0m s/AkUeoIrLi4gj11sMyCc+f0ssKEpQ59Xju3//gqHbfJrd/29WX9yco5s0pFZcWox4tl XP8pAm0b/4RkmqnTKrP7C3l05gtEfXK2hqhtbmU1FUGug75V40wx+OJV85XbM+EMq+wG gURXYuuvo4A1f2EOb2G4h1viATpeMFFDL6O41rikNFcp90qyB/ks+TSxK1/XfL5K9kTY P7Aw== X-Gm-Message-State: AC+VfDyfvEYsbtd94K76JPg+TBsNLyKmOLtbya6W/Rnoh+8ifbHsYXE8 S1MBRyWJTfJ1Gb02ygvkZ4nNBDnGPS98U36CKztDhg== X-Google-Smtp-Source: ACHHUZ6ZLl9FAFgZv7T7gZGWy3LVOp7WfMUJpmQRoNZp2N//Vp6blt2TIamig2Vgxpe5PVROXbu3CI1TU8VYliv/Kzk= X-Received: by 2002:a50:cd47:0:b0:4bc:dee8:94ca with SMTP id d7-20020a50cd47000000b004bcdee894camr23378edj.7.1684962116191; Wed, 24 May 2023 14:01:56 -0700 (PDT) MIME-Version: 1.0 References: <20230518072657.1.If9539da710217ed92e764cc0ba0f3d2d246a1aee@changeid> <52cfebaf-79f6-c318-c14b-3716555d0e8f@intel.com> In-Reply-To: From: Grant Grundler Date: Wed, 24 May 2023 14:01:44 -0700 Message-ID: Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal To: "Loktionov, Aleksandr" Cc: "Nguyen, Anthony L" , Grant Grundler , Pavan Chebbi , "Neftin, Sasha" , "Ruinskiy, Dima" , Ying Hsu , "netdev@vger.kernel.org" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Brandeburg, Jesse" , Paolo Abeni , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 5:34=E2=80=AFAM Loktionov, Aleksandr wrote: > > Good day Tony > > We reviewed the patch and have nothing against. Thank you for reviewing! Can I take this as the equivalent of "Signed-off-by: Loktionov, Aleksandr "? Or since Tony is listed in MAINTAINERS for drivers/net/ethernet/intel, is he supposed to provide that? cheers, grant > > With the best regards > Alex > ND ITP Linux 40G base driver TL > > > > > -----Original Message----- > > From: Nguyen, Anthony L > > Sent: Tuesday, May 23, 2023 8:04 PM > > To: Grant Grundler ; Pavan Chebbi > > ; Loktionov, Aleksandr > > ; Neftin, Sasha = ; > > Ruinskiy, Dima > > Cc: Ying Hsu ; netdev@vger.kernel.org; David S. > > Miller ; Eric Dumazet ; > > Jakub Kicinski ; Brandeburg, Jesse > > ; Paolo Abeni ; intel- > > wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal > > > > On 5/22/2023 1:16 PM, Grant Grundler wrote: > > > On Thu, May 18, 2023 at 3:36=E2=80=AFAM Pavan Chebbi > > wrote: > > >> > > >> On Thu, May 18, 2023 at 12:58=E2=80=AFPM Ying Hsu > > wrote: > > >>> > > >>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > > >>> b/drivers/net/ethernet/intel/igb/igb_main.c > > >>> index 58872a4c2540..a8b217368ca1 100644 > > >>> --- a/drivers/net/ethernet/intel/igb/igb_main.c > > >>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c > > >>> @@ -9581,6 +9581,11 @@ static pci_ers_result_t > > igb_io_error_detected(struct pci_dev *pdev, > > >>> struct net_device *netdev =3D pci_get_drvdata(pdev); > > >>> struct igb_adapter *adapter =3D netdev_priv(netdev); > > >>> > > >>> + if (state =3D=3D pci_channel_io_normal) { > > >>> + dev_warn(&pdev->dev, "Non-correctable non-fatal err= or > > reported.\n"); > > >>> + return PCI_ERS_RESULT_CAN_RECOVER; > > >>> + } > > >>> + > > >> > > >> This code may be good to have. But not sure if this should be the fi= x > > >> for igb_down() synchronization. > > > > > > I have the same opinion. This appears to solve the problem - but I > > > don't know if there is a better way to solve this problem. > > > > > >> Intel guys may comment. > > > > > > Ping? Can we please get feedback from IGB/IGC maintainers this week? > > > > > > (I hope igc maintainers can confirm this isn't an issue for igc.) > > > > Adding some of the igb and igc developers. > > > > > cheers, > > > grant > > > > > >> > > >>> netif_device_detach(netdev); > > >>> > > >>> if (state =3D=3D pci_channel_io_perm_failure) > > >>> -- > > >>> 2.40.1.606.ga4b1b128d6-goog > > >>> > > >>>