From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C582BC77B7C for ; Wed, 24 May 2023 22:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbjEXWfi (ORCPT ); Wed, 24 May 2023 18:35:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238335AbjEXWfe (ORCPT ); Wed, 24 May 2023 18:35:34 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 761F4E4B for ; Wed, 24 May 2023 15:35:09 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f600a6a890so26195e9.0 for ; Wed, 24 May 2023 15:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684967707; x=1687559707; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3B6lMA8fNeW/gE2ngmr6HzgniDM22RVaujvMzuMnMlY=; b=IESF4unk72BCei8C/w6JtEMISo7965mY+cHI6Nj80JeG5+XXzC39bDWhEe4TeEvyv5 i6LZ8SpaB7xNE3oqyQAjTyQnO+tLNBIxOktB9LgnhEsgZ/olOWXdYV3Q+yeE5KzwFsxL uSMC1v6XMxXKpKpmXSJuC2hr7Gt6PtEuN1Eqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684967707; x=1687559707; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3B6lMA8fNeW/gE2ngmr6HzgniDM22RVaujvMzuMnMlY=; b=cDeUgMvAFGVb51UvbH6BwrT9l0WgARes4lBNIdK8QmInHMBQ8w9HHb5DtnjQ9A7VQF OU6kV7s7fYrOhyyTSWRfDUcc6WPnmJ1FfYvpYt/eQwU9o8cJNS40AMFUnNW07GPf63yk 87lgEUE05PYOAPrBcOWNlyqXzEvZ9TJGDB3glL1GTCGRUYZkOogP1EWPcS8KEmHN3aY0 KxoJjr4bOl04OT/J8KJ6ypgYq933hje+kE0I5fjOtsbeC6tftGW3m92FCsOD2AjxNGTC 6MtilsmrLHMLlxDmWiqoE6VrChWZ4PnEGulkySxmbtMhAA9DFqxHa/qTzfdsOvicN4iG BV6Q== X-Gm-Message-State: AC+VfDxBbOw7LaeZBgsNvWk65mTvYh1qvQ8ImrqWxJyb991ZBwl/F/5D kaMppEHZQbdDItEcoSZcuCX6kDI5AAQDM2u0eYAG6Q== X-Google-Smtp-Source: ACHHUZ4kSYulxWJdqL3pmNyCJWNSacql845TBXpP7lD7xJykrXx7wkSJ8/1UOdgGq8LtySP9MrJYiTyoLDc+zDkWyKo= X-Received: by 2002:a05:600c:1c93:b0:3f4:2736:b5eb with SMTP id k19-20020a05600c1c9300b003f42736b5ebmr11744wms.1.1684967707316; Wed, 24 May 2023 15:35:07 -0700 (PDT) MIME-Version: 1.0 References: <20230518072657.1.If9539da710217ed92e764cc0ba0f3d2d246a1aee@changeid> <52cfebaf-79f6-c318-c14b-3716555d0e8f@intel.com> <82a3de3f-acef-c8d9-000c-8a54c2276b77@intel.com> In-Reply-To: <82a3de3f-acef-c8d9-000c-8a54c2276b77@intel.com> From: Grant Grundler Date: Wed, 24 May 2023 15:34:55 -0700 Message-ID: Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal To: Tony Nguyen Cc: Grant Grundler , "Loktionov, Aleksandr" , Pavan Chebbi , "Neftin, Sasha" , "Ruinskiy, Dima" , Ying Hsu , "netdev@vger.kernel.org" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Brandeburg, Jesse" , Paolo Abeni , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 3:22=E2=80=AFPM Tony Nguyen wrote: > > Hi Grant, > > On 5/24/2023 2:01 PM, Grant Grundler wrote: > > On Wed, May 24, 2023 at 5:34=E2=80=AFAM Loktionov, Aleksandr > > wrote: > >> > >> Good day Tony > >> > >> We reviewed the patch and have nothing against. > > > > Thank you for reviewing! > > > > Can I take this as the equivalent of "Signed-off-by: Loktionov, > > Aleksandr "? > > Unless a tag is explicitly given, I don't believe one can be inferred. Yes - that's what I thought and was asking in case that's what Aleksandr meant (and could easily confirm) > > > Or since Tony is listed in MAINTAINERS for drivers/net/ethernet/intel, > > is he supposed to provide that? > > Assuming there's no comments/issues brought up, I'll apply it to the > respective Intel Wired LAN tree for our validation to have a pass at it. > Upon successful completion, I'll send the patch on to netdev for them to > pull. Hope that helps. Yes - that's what I needed to know. Thank you Tony! :) Ying Hsu will apply this patch to Chrome OS kernels: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel= /+/4548800 cheers, grant > > Thanks, > Tony