From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A850C2BAEE for ; Wed, 11 Mar 2020 17:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D764D20746 for ; Wed, 11 Mar 2020 17:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DxkJwdYB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbgCKRU3 (ORCPT ); Wed, 11 Mar 2020 13:20:29 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:45035 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730450AbgCKRU2 (ORCPT ); Wed, 11 Mar 2020 13:20:28 -0400 Received: by mail-vs1-f68.google.com with SMTP id u24so1839841vso.11 for ; Wed, 11 Mar 2020 10:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MEkaiHQZMx1UJA9RPgEM4Gg2VNhyN6paaXR7j/Fo1Hs=; b=DxkJwdYB2pE55yk2uohYiCIxvUd2RfSY0xgbwxZSRdlVNQXspPc65ZzAEqaVwDUvvw HQvs8uHNlP3u+/LIioDnxGa26S8ZMPqF/OJv3pA2r5z5GqhGONIrzSHeT5rt/OumVHTY efB2XSO4fgf1K5Rft2dfoGNnenwPrk5roFVOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MEkaiHQZMx1UJA9RPgEM4Gg2VNhyN6paaXR7j/Fo1Hs=; b=cVczYFHANteQvTFX3CwrWzdhTTc4IJorV26HLbK73JjfX+QBgM4DEhTVRETA0TS4z3 Yd3iSItLsj749ZmxTS/fAjk5q001XT8/vlzXFOAuEjnaZIgY8KRO8P6nJa7RlWq2hNK0 MqvLe3Lqf7Hy/cMNwhGKkFn1Kh3HwzDqiEXB59CBGDpTjrULximP/G43EL3aFSvvNGcl x8nNyLfZe8rfvBYvz8FfNfEUqTwS2BFMHp3ghjCiLlRivEnLH/ApeYB7DR8ZynlivGZM 5fGhzPxxQnXoyrZHKwn3vlEdjKIvyv+9YeqbhHJy985ik6rhqJ7flA/A1Y04BJX/qZn5 ebDA== X-Gm-Message-State: ANhLgQ3r05f0sMEFacdJ5BNvH7vzVIBKpsNj0FNAkQjSjRUGKIu9vtF2 kgBw66SKmR2UM5CIWYQiCjKWNDki/VIigeDgnhKlSw== X-Google-Smtp-Source: ADFU+vsm48zQXYAH+XHZSsly3C3Iz0YrevywINbpKGf7IJNsROsnavS2KVQwpDvPZmQWsJ2sHnsknN2/rlM5sI4a2dk= X-Received: by 2002:a67:f641:: with SMTP id u1mr2714335vso.86.1583947226874; Wed, 11 Mar 2020 10:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20200311155404.209990-1-abhishekpandit@chromium.org> <99C097F2-FD84-49B8-B3D7-F03C34C4F563@holtmann.org> In-Reply-To: <99C097F2-FD84-49B8-B3D7-F03C34C4F563@holtmann.org> From: Abhishek Pandit-Subedi Date: Wed, 11 Mar 2020 10:20:16 -0700 Message-ID: Subject: Re: [RFC PATCH v6 0/5] Bluetooth: Handle system suspend gracefully To: Marcel Holtmann Cc: Luiz Augusto von Dentz , Alain Michaud , Bluez mailing list , ChromeOS Bluetooth Upstreaming , "David S. Miller" , Johan Hedberg , netdev , LKML , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's continue the discussion on the bluez list. I will update the patch series so that the "set_wake_capable" management change is last in the series there as well and send out an update today. Thanks Abhishek On Wed, Mar 11, 2020 at 10:05 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > This patch series prepares the Bluetooth controller for system suspend > > by disconnecting all devices and preparing the event filter and LE > > whitelist with devices that can wake the system from suspend. > > > > The main motivation for doing this is so we can enable Bluetooth as > > a wake up source during suspend without it being noisy. Bluetooth should > > wake the system when a HID device receives user input but otherwise not > > send any events to the host. > > > > This patch series was tested on several Chromebooks with both btusb and > > hci_serdev on kernel 4.19. The set of tests was basically the following: > > * Reconnects after suspend succeed > > * HID devices can wake the system from suspend (needs some related bluez > > changes to call the Set Wake Capable management command) > > * System properly pauses and unpauses discovery + advertising around > > suspend > > * System does not wake from any events from non wakeable devices > > > > Series 2 has refactored the change into multiple smaller commits as > > requested. I tried to simplify some of the whitelist filtering edge > > cases but unfortunately it remains quite complex. > > > > Series 3 has refactored it further and should have resolved the > > whitelisting complexity in series 2. > > > > Series 4 adds a fix to check for powered down and powering down adapters. > > > > Series 5 moves set_wake_capable to the last patch in the series and > > changes BT_DBG to bt_dev_dbg. > > > > Please review and provide any feedback. > > > > Thanks > > Abhishek > > > > > > Changes in v6: > > * Removed unused variables in hci_req_prepare_suspend > > * Add int old_state to this patch > > > > Changes in v5: > > * Convert BT_DBG to bt_dev_dbg > > * Added wakeable list and changed BT_DBG to bt_dev_dbg > > * Add wakeable to hci_conn_params and change BT_DBG to bt_dev_dbg > > * Changed BT_DBG to bt_dev_dbg > > * Wakeable entries moved to other commits > > * Patch moved to end of series > > > > Changes in v4: > > * Added check for mgmt_powering_down and hdev_is_powered in notifier > > > > Changes in v3: > > * Refactored to only handle BR/EDR devices > > * Split LE changes into its own commit > > * Added wakeable property to le_conn_param > > * Use wakeable list for BR/EDR and wakeable property for LE > > > > Changes in v2: > > * Moved pm notifier registration into its own patch and moved params out > > of separate suspend_state > > * Refactored filters and whitelist settings to its own patch > > * Refactored update_white_list to have clearer edge cases > > * Add connected devices to whitelist (previously missing corner case) > > * Refactored pause discovery + advertising into its own patch > > > > Abhishek Pandit-Subedi (5): > > Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND > > Bluetooth: Handle BR/EDR devices during suspend > > Bluetooth: Handle LE devices during suspend > > Bluetooth: Pause discovery and advertising during suspend > > Bluetooth: Add mgmt op set_wake_capable > > > > include/net/bluetooth/hci.h | 17 +- > > include/net/bluetooth/hci_core.h | 43 ++++ > > include/net/bluetooth/mgmt.h | 7 + > > net/bluetooth/hci_core.c | 102 ++++++++++ > > net/bluetooth/hci_event.c | 24 +++ > > net/bluetooth/hci_request.c | 331 ++++++++++++++++++++++++++----- > > net/bluetooth/hci_request.h | 2 + > > net/bluetooth/mgmt.c | 92 +++++++++ > > 8 files changed, 558 insertions(+), 60 deletions(-) > > patches 1-4 have been applied to bluetooth-next tree. > > I skipped patch 5 since now we have to discuss how best the API for setting the wakeable devices will be. Care to start up a discussion thread for that? > > Regards > > Marcel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, PDS_HP_HELO_NORDNS,RDNS_NONE,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail-vs1-f68.google.com ([209.85.217.68]:45035 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730450AbgCKRU2 (ORCPT ); Wed, 11 Mar 2020 13:20:28 -0400 Received: by mail-vs1-f68.google.com with SMTP id u24so1839841vso.11 for ; Wed, 11 Mar 2020 10:20:27 -0700 (PDT) MIME-Version: 1.0 References: <20200311155404.209990-1-abhishekpandit@chromium.org> <99C097F2-FD84-49B8-B3D7-F03C34C4F563@holtmann.org> In-Reply-To: <99C097F2-FD84-49B8-B3D7-F03C34C4F563@holtmann.org> From: Abhishek Pandit-Subedi Date: Wed, 11 Mar 2020 10:20:16 -0700 Message-ID: Subject: Re: [RFC PATCH v6 0/5] Bluetooth: Handle system suspend gracefully To: Marcel Holtmann Cc: Luiz Augusto von Dentz , Alain Michaud , Bluez mailing list , ChromeOS Bluetooth Upstreaming , "David S. Miller" , Johan Hedberg , netdev , LKML , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: Message-ID: <20200311172016.9mNnx_kdDK3tC2ZoHBBgvCSfjnmZJgeXFOmmXiOVW8w@z> Let's continue the discussion on the bluez list. I will update the patch series so that the "set_wake_capable" management change is last in the series there as well and send out an update today. Thanks Abhishek On Wed, Mar 11, 2020 at 10:05 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > This patch series prepares the Bluetooth controller for system suspend > > by disconnecting all devices and preparing the event filter and LE > > whitelist with devices that can wake the system from suspend. > > > > The main motivation for doing this is so we can enable Bluetooth as > > a wake up source during suspend without it being noisy. Bluetooth should > > wake the system when a HID device receives user input but otherwise not > > send any events to the host. > > > > This patch series was tested on several Chromebooks with both btusb and > > hci_serdev on kernel 4.19. The set of tests was basically the following: > > * Reconnects after suspend succeed > > * HID devices can wake the system from suspend (needs some related bluez > > changes to call the Set Wake Capable management command) > > * System properly pauses and unpauses discovery + advertising around > > suspend > > * System does not wake from any events from non wakeable devices > > > > Series 2 has refactored the change into multiple smaller commits as > > requested. I tried to simplify some of the whitelist filtering edge > > cases but unfortunately it remains quite complex. > > > > Series 3 has refactored it further and should have resolved the > > whitelisting complexity in series 2. > > > > Series 4 adds a fix to check for powered down and powering down adapters. > > > > Series 5 moves set_wake_capable to the last patch in the series and > > changes BT_DBG to bt_dev_dbg. > > > > Please review and provide any feedback. > > > > Thanks > > Abhishek > > > > > > Changes in v6: > > * Removed unused variables in hci_req_prepare_suspend > > * Add int old_state to this patch > > > > Changes in v5: > > * Convert BT_DBG to bt_dev_dbg > > * Added wakeable list and changed BT_DBG to bt_dev_dbg > > * Add wakeable to hci_conn_params and change BT_DBG to bt_dev_dbg > > * Changed BT_DBG to bt_dev_dbg > > * Wakeable entries moved to other commits > > * Patch moved to end of series > > > > Changes in v4: > > * Added check for mgmt_powering_down and hdev_is_powered in notifier > > > > Changes in v3: > > * Refactored to only handle BR/EDR devices > > * Split LE changes into its own commit > > * Added wakeable property to le_conn_param > > * Use wakeable list for BR/EDR and wakeable property for LE > > > > Changes in v2: > > * Moved pm notifier registration into its own patch and moved params out > > of separate suspend_state > > * Refactored filters and whitelist settings to its own patch > > * Refactored update_white_list to have clearer edge cases > > * Add connected devices to whitelist (previously missing corner case) > > * Refactored pause discovery + advertising into its own patch > > > > Abhishek Pandit-Subedi (5): > > Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND > > Bluetooth: Handle BR/EDR devices during suspend > > Bluetooth: Handle LE devices during suspend > > Bluetooth: Pause discovery and advertising during suspend > > Bluetooth: Add mgmt op set_wake_capable > > > > include/net/bluetooth/hci.h | 17 +- > > include/net/bluetooth/hci_core.h | 43 ++++ > > include/net/bluetooth/mgmt.h | 7 + > > net/bluetooth/hci_core.c | 102 ++++++++++ > > net/bluetooth/hci_event.c | 24 +++ > > net/bluetooth/hci_request.c | 331 ++++++++++++++++++++++++++----- > > net/bluetooth/hci_request.h | 2 + > > net/bluetooth/mgmt.c | 92 +++++++++ > > 8 files changed, 558 insertions(+), 60 deletions(-) > > patches 1-4 have been applied to bluetooth-next tree. > > I skipped patch 5 since now we have to discuss how best the API for setting the wakeable devices will be. Care to start up a discussion thread for that? > > Regards > > Marcel >