From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A9EC3F2CD for ; Mon, 23 Mar 2020 17:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E314E2072D for ; Mon, 23 Mar 2020 17:59:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oac+Na4Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727601AbgCWR7u (ORCPT ); Mon, 23 Mar 2020 13:59:50 -0400 Received: from mail-vk1-f195.google.com ([209.85.221.195]:40075 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727091AbgCWR7u (ORCPT ); Mon, 23 Mar 2020 13:59:50 -0400 Received: by mail-vk1-f195.google.com with SMTP id k63so4047871vka.7 for ; Mon, 23 Mar 2020 10:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N1lNiHO6xPgUYO8vpSF+umT+MsS9oLeQwMA1IUK4msY=; b=oac+Na4QF5JdaT66BiopNbxc1KdXssKfiBlw2slQLPbJQBivpZ0EN0e6Sgvlv3MlYt LFkGEQSOGmkteEnbM8Sa5xhzWzDoK40s+TbvrvTQ4l0I2NLeiOBlHX3V2ZDM+gX9fHCA dE2zVE+twtdZnNDIfr1GiogTDw8RQHAcUZxP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N1lNiHO6xPgUYO8vpSF+umT+MsS9oLeQwMA1IUK4msY=; b=K/8A9fwl6RDfNglv3Lz4aEojNlSptKr1hpXl4JnHcWLRk9jriItTaeO+y7es3O9Se8 xvIjgD6eA/6OrewRHOnKAroQC0ynYa0L9o4Pc8uBJhcgxIcqZZPUJ2CZEIU/8mK+cHWb 45h0P2W7ObcttK1GgKEnQDtkjAauh14UpkrhhMsd0boq08fEwBVPPjyW1prGXZLIsTwd Wn+k0bc3HTUU9sYmjXcrNFvu/iYVDactpcakXvcNOjw9yb/cUWsTAMl0DJiuLw1srTp5 /G8c9swjPIZ+ooTAaChV/43EX6+YQ4MgOoCRZGv6mTUmGhZc79Jxg7y8Xts596gqZtRu Ddww== X-Gm-Message-State: ANhLgQ3QFQMx2Pdvta2Ma3WWg/RwWxcDJMJYNngOMYyECfrLEZKTgn9H yUPuPwlbo3VXEPcF/q1dSKwlI78Q/WlVI49RwLfBUA== X-Google-Smtp-Source: ADFU+vuVSdd2udzk4DKElzSYL+hMRvTEKcwyCXXYbubzZcZarmIuxkLsTjU4cHyyKYLHSKOKQBZQbz5oZXm8FdykO60= X-Received: by 2002:a1f:43:: with SMTP id 64mr15772046vka.100.1584986389210; Mon, 23 Mar 2020 10:59:49 -0700 (PDT) MIME-Version: 1.0 References: <20200320000713.32899-1-abhishekpandit@chromium.org> In-Reply-To: From: Abhishek Pandit-Subedi Date: Mon, 23 Mar 2020 10:59:37 -0700 Message-ID: Subject: Re: [PATCH 0/2] Bluetooth: Suspend related bugfixes To: Marcel Holtmann Cc: Bluez mailing list , ChromeOS Bluetooth Upstreaming , "David S. Miller" , Johan Hedberg , Network Development , LKML , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Marcel. On Mon, Mar 23, 2020 at 10:50 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > After further automated testing of the upstreamed suspend patches, > > I found two issues: > > - A failure in PM_SUSPEND_PREPARE wasn't calling PM_POST_SUSPEND. > > I misread the docs and thought it would call it for all notifiers > > already run but it only does so for the ones that returned > > successfully from PM_SUSPEND_PREPARE. > > - hci_conn_complete_evt wasn't completing on auto-connects (an else > > block was removed during a refactor incorrectly) > > > > With the following patches, I've run a suspend stress test on a couple > > of Chromebooks for several dozen iterations (each) successfully. > > > > Thanks > > Abhishek > > > > > > > > Abhishek Pandit-Subedi (2): > > Bluetooth: Restore running state if suspend fails > > Bluetooth: Fix incorrect branch in connection complete > > > > net/bluetooth/hci_core.c | 39 ++++++++++++++++++++------------------- > > net/bluetooth/hci_event.c | 17 +++++++++-------- > > 2 files changed, 29 insertions(+), 27 deletions(-) > > both patches have been applied to bluetooth-next tree. > > Regards > > Marcel >