From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbcHHOoy (ORCPT ); Mon, 8 Aug 2016 10:44:54 -0400 Received: from mail-yb0-f173.google.com ([209.85.213.173]:35170 "EHLO mail-yb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbcHHOox (ORCPT ); Mon, 8 Aug 2016 10:44:53 -0400 X-Greylist: delayed 393 seconds by postgrey-1.27 at vger.kernel.org; Mon, 08 Aug 2016 10:44:53 EDT MIME-Version: 1.0 In-Reply-To: <87mvknmt6j.fsf@ashishki-desk.ger.corp.intel.com> References: <1469742143-22245-1-git-send-email-mathieu.poirier@linaro.org> <1469742143-22245-3-git-send-email-mathieu.poirier@linaro.org> <20160804171903.GV6862@twins.programming.kicks-ass.net> <87mvknmt6j.fsf@ashishki-desk.ger.corp.intel.com> From: Mathieu Poirier Date: Mon, 8 Aug 2016 08:38:18 -0600 Message-ID: Subject: Re: [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() To: Alexander Shishkin Cc: Peter Zijlstra , Arnaldo Carvalho de Melo , jolsa@kernel.org, Ingo Molnar , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 August 2016 at 04:49, Alexander Shishkin wrote: > Peter Zijlstra writes: > >> On Thu, Jul 28, 2016 at 03:42:19PM -0600, Mathieu Poirier wrote: >>> Some information, like driver specific configuration, is found >>> in the hw_perf_event structure. As such pass a 'struct perf_event' >>> to function setup_aux() rather than just the CPU number so that >>> individual drivers can make the right configuration when setting >>> up a session. >>> >>> Signed-off-by: Mathieu Poirier >>> Cc: Alexander Shishkin >> >> Yeah, no objection to this. > > Sure, but I'd like a commit message that actually describes *what* > information and *why*. Sure, I'll make it more explicit in the next revision. Mathieu > > Regards, > -- > Alex