From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] drivers/hwtracing: add missing header dependencies
Date: Tue, 6 Sep 2016 09:27:09 -0600 [thread overview]
Message-ID: <CANLsYkxkSoQgeJoygOV+1mP=H+_+wVYgGFiAxia2juskEDf=qg@mail.gmail.com> (raw)
In-Reply-To: <1473148597-25478-1-git-send-email-baoyou.xie@linaro.org>
On 6 September 2016 at 01:56, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes]
>
> In fact, this function is declared in coresight-etm-perf.h, so this patch
> add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 755125f..d936e82 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -28,6 +28,7 @@
> #include <linux/workqueue.h>
>
> #include "coresight-priv.h"
> +#include "coresight-etm-perf.h"
I already fixed this one in my next branch - it will show up in the 4.9 cycle.
Thanks for the submission,
Mathieu
>
> static struct pmu etm_pmu;
> static bool etm_perf_up;
> --
> 2.7.4
>
prev parent reply other threads:[~2016-09-06 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 7:56 [PATCH] drivers/hwtracing: add missing header dependencies Baoyou Xie
2016-09-06 15:27 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLsYkxkSoQgeJoygOV+1mP=H+_+wVYgGFiAxia2juskEDf=qg@mail.gmail.com' \
--to=mathieu.poirier@linaro.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).