From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDEE8C282C4 for ; Mon, 4 Feb 2019 18:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79598206DD for ; Mon, 4 Feb 2019 18:41:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="gZte/vq0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729301AbfBDSll (ORCPT ); Mon, 4 Feb 2019 13:41:41 -0500 Received: from mail-it1-f193.google.com ([209.85.166.193]:50689 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfBDSll (ORCPT ); Mon, 4 Feb 2019 13:41:41 -0500 Received: by mail-it1-f193.google.com with SMTP id z7so2273733iti.0 for ; Mon, 04 Feb 2019 10:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lljpl7F6zGmvejmshc6cYjVTXsqTpItV4tTHwcOZF7s=; b=gZte/vq0HZN62BhtZykofDHyOeDZp9bXxXJlXywZRIaAKKhILJLCgZ+qalpoACyZAU NY4UXBRui0T23mNU7FimPmfYIGSQcJhDr/hngOjEnmHKm1sIIMKpEw+9++XC0eBxLhT0 nVYS2QSzMa2GSWvtxAue8f36KyFfxzGIGK6ag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lljpl7F6zGmvejmshc6cYjVTXsqTpItV4tTHwcOZF7s=; b=JwkrBCC/yDHs5L/eMG13kDxdgJXbfMkuJbBNEmHmIDcWxb8V0vXN8CIOAY0K10FO8p BAAu9F6KuOHjMiEADgYFZvUoiw5H/nlgpwZ+H5MQ8dcy9nycUMJGFelMzthRrj4LV0Hb X3mzUxFjNk8o6KqRiGk3vGFWLp2GVUTy1vc2wMNPtz4D6qXbw3EEh2T9AkwWbHF/I3a/ dGid6UDqSqSCWSmvG/TVNCyVk1uRIIigyOJuojz4Te8Gbv6vljxjUr1/sRhYXQhB+eT0 fXaqncTT5vUvWcC9uDt9T95gf7KA4SD/E6TGeCBefTYOVno00EyUdSexRels14VS0tfK fb9A== X-Gm-Message-State: AHQUAuZ9sO9IHdvXgmtVW6F7EtgUKelb7Q5l59Xd25gajfKADGxFZJwp ESDYdMEXtUjo50vSLrq5v2cqAuKkw7FvJN+wsfOLIg== X-Google-Smtp-Source: AHgI3IYB0MwFB0ae73F8bKxk0QbZbLvMoNHkh5r3uYBwl6TcLI3HNivcc/wmdlYyeoPjGK66yexPmdC3fPVIrH2/mis= X-Received: by 2002:a5d:960e:: with SMTP id w14mr459746iol.86.1549305699635; Mon, 04 Feb 2019 10:41:39 -0800 (PST) MIME-Version: 1.0 References: <20190129122842.32041-1-leo.yan@linaro.org> In-Reply-To: <20190129122842.32041-1-leo.yan@linaro.org> From: Mathieu Poirier Date: Mon, 4 Feb 2019 11:41:28 -0700 Message-ID: Subject: Re: [PATCH v7 0/8] perf cs-etm: Add support for sample flags To: Leo Yan Cc: Arnaldo Carvalho de Melo , Suzuki K Poulose , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , Robert Walker , linux-arm-kernel , Linux Kernel Mailing List , Coresight ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Jan 2019 at 05:29, Leo Yan wrote: > > This patch seris adds support for sample flags so can facilitate perf > to print sample flags for branch instruction. > > Patch 0001 is used to save last branch information in packet structure, > this includes instruction type, subtype and condition flag to help > making decision for which branch instruction it is. It passes related > information from decoder layer to cs-etm.c, so we use cs-etm.c as a > central place to set sample flags. > > Patch 0002 is used to set sample flags for instruction range packet. > > Patch 0003 is used to set sample flags for trace discontinuity packet. > > Patches 0004/0005/0006 are preparation for exception packet handling: > Patch 0004 addes exception number in packet; pacth 0005/0006 is to use > traceID/metadata tuple to access metadata pointer based on traceID, this > can help decide if the CPU is connected with ETMv3 or ETMv4, ETMv3 and > ETMv4 have totally different definition for exception numbers. > > Patch 0007 sets sample flags for exception packet; patch 0008 support > sample flags for exception return packet. > > This patch set is applied on the acme's perf core branch with the latest > commit bdec77cfe58d ("Merge remote-tracking branch 'tip/perf/urgent' > into perf/core"). > > This patch set has been verified for x86 and arm64 perf building and > also is verified with below command: > > Before: > > # perf script -F,-time,+flags -k vmlinux > > [...] > > main 6650 [001] 1 branches: f7b08490 lib_loop_test+0xc (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: f7b084b0 lib_loop_test+0x2c (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: 6b65a8 main+0x1c (/root/coresight_test/main) > main 6650 [001] 1 branches: 6b6448 printf@plt+0x8 (/root/coresight_test/main) > main 6650 [001] 1 branches: 6b642c _init+0x18 (/root/coresight_test/main) > main 6650 [001] 1 branches: f7b2d23c [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2906e [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b255ee [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: f7b25634 [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > > [...] > > > After: > > # perf script -F,-time,+flags -k vmlinux > > [...] > > main 6650 [001] 1 branches: jmp f7b08490 lib_loop_test+0xc (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: jcc f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: jcc f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: jcc f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: jcc f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: jcc f7b084a2 lib_loop_test+0x1e (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: return f7b084b0 lib_loop_test+0x2c (/root/coresight_test/libcstest.so) > main 6650 [001] 1 branches: call 6b65a8 main+0x1c (/root/coresight_test/main) > main 6650 [001] 1 branches: return 6b6448 printf@plt+0x8 (/root/coresight_test/main) > main 6650 [001] 1 branches: return 6b642c _init+0x18 (/root/coresight_test/main) > main 6650 [001] 1 branches: call f7b2d23c [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: call f7b2906e [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jcc f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jcc f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jcc f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jcc f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jcc f7b2559a [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: jmp f7b255ee [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > main 6650 [001] 1 branches: call f7b25634 [unknown] (/usr/lib/arm-linux-gnueabihf/ld-2.27.so) > > [...] Good day Arnaldo, I have reviewed, compiled and tested this patchset - please consider for inclusion. Regards, Mathieu > > > Changes from v6: > * Addressed Mathieu's suggestion for patch 0005, refined its commit log > and comment and fixed cs_etm__get_cpu() definitions in header file; > also tested with perf for Arm and x86 buildings. > * Added Mathieu's review tags. > > Changes from v5: > * Addressed Rob's suggestion to add specification info for exception > number encoding; > * Added Rob's review tag in patch 0007. > > Changes from v4: > * Fixed typos in comments, and removed redundant info from commit log; > * Addressed Mathieu's suggestion to add helper functions for metadata > fields (CS_ETM_CPU and CS_ETM_MAGIC) accessing; > * Addressed Mathieu's suggestion to include headers with alphabetical > order. > > Changes from v3: > * Fixed typos in commit logs; > * Rearranged fields in cs_etm_packet by grouping with same variable > types; > * Fixed ETMv4 exception number which pointed by Mike; > * Fixed ETMv4 SVC / SMC / HVC in the same CALL, by checking svc > instruction to distinguish them; > * Refine ETMv4 return exception packet handling. > > Changes from v2: > * Addressed Mathieu's suggestion to split one big patch to 3 small > patches for setting sample flags, one is for instruction range > packet, one is for discontinuity packet and one is for exception > packet. > * Added supporting for ETMv3 exception packet. > * Followed Mathieu's suggestion to move all sample flags handling > from decoder layer to cs-etm.c, thus it has enough info to set flags > based on trace context in single place. > > Changes from v1: > * Moved exception packets handling patches into patch series 'perf > cs-etm: Correct packets handling'. > * Added sample flags fixing up for TRACE_OFF packet. > * Created a new function which is used to maintain flags fixing up. > > > Leo Yan (8): > perf cs-etm: Add last instruction information in packet > perf cs-etm: Set sample flags for instruction range packet > perf cs-etm: Set sample flags for trace discontinuity > perf cs-etm: Add exception number in exception packet > perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata > perf cs-etm: Add traceID in packet > perf cs-etm: Set sample flags for exception packet > perf cs-etm: Set sample flags for exception return packet > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 41 +- > .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 6 + > tools/perf/util/cs-etm.c | 394 +++++++++++++++++- > tools/perf/util/cs-etm.h | 53 ++- > 4 files changed, 476 insertions(+), 18 deletions(-) > > -- > 2.17.1 >