From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754250AbcH2P7V (ORCPT ); Mon, 29 Aug 2016 11:59:21 -0400 Received: from mail-yb0-f182.google.com ([209.85.213.182]:33672 "EHLO mail-yb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbcH2P7T (ORCPT ); Mon, 29 Aug 2016 11:59:19 -0400 MIME-Version: 1.0 In-Reply-To: <20160828141808.GC32293@krava> References: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org> <20160828141808.GC32293@krava> From: Mathieu Poirier Date: Mon, 29 Aug 2016 09:58:51 -0600 Message-ID: Subject: Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , jolsa@kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28 August 2016 at 08:18, Jiri Olsa wrote: > On Thu, Aug 25, 2016 at 02:20:40PM -0600, Mathieu Poirier wrote: > > SNIP > >> perf record -e some_event/@cfg1,@cfg2=config/ ... >> >> The above are all valid configuration and will see the strings 'cfg1' >> and 'cfg2=config' sent to the PMU driver for parsing and interpretation >> using the existing ioctl() mechanism. >> >> The primary customers for this feature are the CoreSight drivers where >> the selection of a sink (where trace data is accumulated) needs to be >> done in a previous, and separated step, from the launching of the perf >> command. >> >> As such something that used to be a two-step process: >> >> # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink >> # perf record -e cs_etm//u --per-thread uname >> >> is integrated in a single command: >> >> # perf record -e cs_etm/@20070000.etr/u --per-thread uname >> >> Thanks, >> Mathieu >> >> Changes for V6: >> - Using sysFS rather than an ioctl() to communicate command line >> parameters to the CoreSight PMU. > > apart from few nits it looks good.. but can't say for patch 2/5 ;-) > > Acked-by: Jiri Olsa > Many thanks for taking the time to look at this set - your time is much appreciated. > thanks, > jirka