From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 03/12] coresight: Extend the PIDR mask to cover relevant bits in PIDR2
Date: Tue, 13 Jun 2017 13:06:05 -0600 [thread overview]
Message-ID: <CANLsYkz3sEogjAaeHW6KYnV5nrgu-7NYs3N+ML0jtWSN+vu+7w@mail.gmail.com> (raw)
In-Reply-To: <e6c64a07-1354-b513-349e-242380f5fb59@arm.com>
On 13 June 2017 at 11:55, Suzuki K Poulose <Suzuki.Poulose@arm.com> wrote:
> On 13/06/17 18:53, Mathieu Poirier wrote:
>>
>> On Mon, Jun 12, 2017 at 03:36:42PM +0100, Suzuki K Poulose wrote:
>>>
>>> As per coresight standards, PIDR2 register has the following format :
>>>
>>> [2-0] - JEP106_bits6to4
>>> [3] - JEDEC, designer ID is specified by JEDEC.
>>>
>>> However some of the drivers only use mask of 0x3 for the PIDR2 leaving
>>> bits [3-2] unchecked, which could potentially match the component for
>>> a different device altogether. This patch fixes the mask and the
>>> corresponding id bits for the existing devices.
>>>
>>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>> ---
>>> I have not touched the TPIU ids for Ux500 (see commit: 4339b699),
>>> as I don't have a platform to fix/correct the ids.
>>> ---
>>> drivers/hwtracing/coresight/coresight-funnel.c | 4 ++--
>>> drivers/hwtracing/coresight/coresight-replicator-qcom.c | 4 ++--
>>> drivers/hwtracing/coresight/coresight-stm.c | 8 ++++----
>>> drivers/hwtracing/coresight/coresight-tmc.c | 4 ++--
>>> drivers/hwtracing/coresight/coresight-tpiu.c | 4 ++--
>>
>>
>> Any reason for not adding ETMv3 to the list? From what I see in the
>> documentation bit [2-0] need to 0b011 and the JEDEC bit is always 1.
>
>
> I don't have a platform to test it easily. Hence the exclusion. Same for
> etbv10.
I have a TC2 - add them in and I'll test it.
>
>
> Suzuki
>
next prev parent reply other threads:[~2017-06-13 19:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 14:36 [PATCH 00/12] coresight: Support for ARM Coresight SoC-600 Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 01/12] coresight replicator: Cleanup programmable replicator naming Suzuki K Poulose
2017-06-13 16:55 ` Mathieu Poirier
2017-06-13 17:56 ` Suzuki K Poulose
2017-06-18 14:04 ` Rob Herring
2017-06-20 16:44 ` Mathieu Poirier
2017-06-22 3:21 ` Rob Herring
2017-06-12 14:36 ` [PATCH 02/12] arm64: dts: juno: Use the new coresight replicator string Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 03/12] coresight: Extend the PIDR mask to cover relevant bits in PIDR2 Suzuki K Poulose
2017-06-13 17:53 ` Mathieu Poirier
2017-06-13 17:55 ` Suzuki K Poulose
2017-06-13 19:06 ` Mathieu Poirier [this message]
2017-06-12 14:36 ` [PATCH 04/12] coresight: Add support for reading 64bit registers Suzuki K Poulose
2017-06-13 17:45 ` Mathieu Poirier
2017-06-13 17:57 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 05/12] coresight tmc: Add helpers for accessing " Suzuki K Poulose
2017-06-14 17:49 ` Mathieu Poirier
2017-06-15 10:13 ` Suzuki K Poulose
2017-06-15 13:29 ` Mike Leach
2017-06-15 14:24 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 06/12] coresight tmc: Expose DBA and AXICTL Suzuki K Poulose
2017-06-14 17:50 ` Mathieu Poirier
2017-06-15 10:19 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 07/12] coresight replicator: Expose replicator management registers Suzuki K Poulose
2017-06-14 17:54 ` Mathieu Poirier
2017-06-15 10:23 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 08/12] coresight tmc: Handle configuration types properly Suzuki K Poulose
2017-06-14 17:59 ` Mathieu Poirier
2017-06-15 10:25 ` Suzuki K Poulose
2017-06-15 14:33 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 09/12] coresight tmc: Add capability information Suzuki K Poulose
2017-06-14 18:22 ` Mathieu Poirier
2017-06-15 10:30 ` Suzuki K Poulose
2017-06-15 14:37 ` Mathieu Poirier
2017-06-12 14:36 ` [PATCH 10/12] coresight tmc: Support for save-restore in ETR Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 11/12] coresight tmc: Add support for Coresight SoC 600 TMC Suzuki K Poulose
2017-06-14 18:25 ` Mathieu Poirier
2017-06-15 10:31 ` Suzuki K Poulose
2017-06-12 14:36 ` [PATCH 12/12] coresight: Add support for Coresight SoC 600 components Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANLsYkz3sEogjAaeHW6KYnV5nrgu-7NYs3N+ML0jtWSN+vu+7w@mail.gmail.com \
--to=mathieu.poirier@linaro.org \
--cc=Suzuki.Poulose@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).