From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753352AbcCNRYu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Mar 2016 13:24:50 -0400
Received: from mail-vk0-f44.google.com ([209.85.213.44]:35551 "EHLO
	mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752480AbcCNRYq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Mar 2016 13:24:46 -0400
MIME-Version: 1.0
In-Reply-To: <1457970301-24616-3-git-send-email-tomeu.vizoso@collabora.com>
References: <1457970301-24616-1-git-send-email-tomeu.vizoso@collabora.com>
	<1457970301-24616-3-git-send-email-tomeu.vizoso@collabora.com>
Date: Mon, 14 Mar 2016 10:24:45 -0700
X-Google-Sender-Auth: AYG9yEMXh8gon6W8025KFSObkzw
Message-ID: <CANLzEksMbB6tZTOiOPt+ZrF7foki1Y-m_Hg++xUAtbuTPRsGPA@mail.gmail.com>
Subject: Re: [PATCH v5 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper
From: Benson Leung <bleung@chromium.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sameer Nanda <snanda@chromium.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Lee Jones <lee.jones@linaro.org>,
        =?UTF-8?Q?Enric_Balletb=C3=B2?= <enric.balletbo@collabora.co.uk>,
        Vic Yang <victoryang@chromium.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Vincent Palatin <vpalatin@chromium.org>,
        Randall Spangler <rspangler@chromium.org>,
        Todd Broch <tbroch@chromium.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Olof Johansson <olof@lixom.net>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks!

On Mon, Mar 14, 2016 at 8:44 AM, Tomeu Vizoso
<tomeu.vizoso@collabora.com> wrote:
> So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate
> code when checking for errors from the EC side.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
>
> Changes in v5:
> - Check explicitly for !EC_RES_SUCCESS as suggested by Benson Leung.
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None




-- 
Benson Leung
Senior Software Engineer, Chrom* OS
bleung@chromium.org