From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbcHHQRX (ORCPT ); Mon, 8 Aug 2016 12:17:23 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33669 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbcHHQRU (ORCPT ); Mon, 8 Aug 2016 12:17:20 -0400 MIME-Version: 1.0 In-Reply-To: <1470672663-10829-1-git-send-email-robert.foss@collabora.com> References: <1470672663-10829-1-git-send-email-robert.foss@collabora.com> From: Benson Leung Date: Mon, 8 Aug 2016 09:16:59 -0700 X-Google-Sender-Auth: ufRwWjjt0FF0h-asmhuuZIMP0mE Message-ID: Subject: Re: [PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted To: robert.foss@collabora.com Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andrew Bresticker , Kevin Cernekee , Christopher Freeman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 8, 2016 at 9:11 AM, wrote: > > From: Christopher Freeman > > wait_event_interruptible_timeout() will return early if the blocked > process receives a signal, causing the driver to abort the tuning > procedure and possibly leaving the controller in a bad state. Since the > tuning command is expected to complete quickly (<50ms) and we've set a > timeout, use wait_event_timeout() instead. > > Signed-off-by: Christopher Freeman > Tested-by: Robert Foss > Signed-off-by: Robert Foss Reviewed-by: Benson Leung Thanks Robert! -- Benson Leung Senior Software Engineer, Chrom* OS bleung@chromium.org