From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2DB1C10DCE for ; Fri, 6 Mar 2020 12:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BB6D2072D for ; Fri, 6 Mar 2020 12:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Lrp8JGAi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbgCFMLU (ORCPT ); Fri, 6 Mar 2020 07:11:20 -0500 Received: from mail-vk1-f193.google.com ([209.85.221.193]:35715 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgCFMLU (ORCPT ); Fri, 6 Mar 2020 07:11:20 -0500 Received: by mail-vk1-f193.google.com with SMTP id r5so536762vkf.2 for ; Fri, 06 Mar 2020 04:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=0TUqo6ABKjwBnwDPZcgrzkhlR/76Lf46MG8q+lDRB/8=; b=Lrp8JGAiHwHwWX0IhOfZnqln4zidFkjpkzJZc5IITIoiGy+D5onYZVtO/J77i20f0U E5/tYpu+oeJjp5Ek57MA/FDMMSQ2kSxqccAD3kIMoucdeTGVqIBGtY480HtRL5arKs0f TKyBrdvSML8aVPRNV1R+JwUz3nHMvSb99nsL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=0TUqo6ABKjwBnwDPZcgrzkhlR/76Lf46MG8q+lDRB/8=; b=rQdgNrgPkEigWydzVsEMj9RVZUvubf1tyNI7ljhJ9huIKKlOtU95Ai1TwDo8Wbymyo TexhgL+iAuFcqXe3dT+OCH2LRIw2GJ72ecTdwVbFglmX9NQNb7CeXbcKfmptN02MQZtz JDQov/G4htwMeJSGuQBKpKQSf6SR66k9vH5q0F0TPtggaOITTgd7utbqnG92d5RVHFMp q62ARsrhLmTTrJ9IpsI0x0vHVY3KIBZzYT9r+2Mfg2xSR20oaEN3/JGa921wg0QZxho2 QLG/fGH5+wZYd8RsDhxB1hij2DKOtcDvwBY0an3Lj/waL3PiXgEiqeb4X8rRZsUkcdc5 L/sg== X-Gm-Message-State: ANhLgQ36aalJ2tAfMlobXlkkMl/u8OxQWiLyxmA0GO7XVyZwJKqXd+hO KkKnp/IAe9Lz0aRk3yypBIT34X3VbpW7/mL6TdK0iA== X-Google-Smtp-Source: ADFU+vubNpp5WuQGslML1DFO7WzoJzlruVOXAnHZ2XSMzf1yBhULppWC4mBeJHnBzL21C/ktAd6KdRlpH+x9FLeKDso= X-Received: by 2002:a1f:aac1:: with SMTP id t184mr1393354vke.33.1583496678551; Fri, 06 Mar 2020 04:11:18 -0800 (PST) MIME-Version: 1.0 References: <5245a8e4-2320-46bd-04fd-f86ce6b17ce7@collabora.com> <20200305193505.4km5j7n25ph4b6hn@core.my.home> <2a5a4a62-3189-e053-21db-983a4c766d44@collabora.com> <5d72a8c6824b31163a303b5ef1526efe05121e5d.camel@aosc.io> <20200306120726.t7aitfz5rq3m7m6y@core.my.home> In-Reply-To: <20200306120726.t7aitfz5rq3m7m6y@core.my.home> From: Nicolas Boichat Date: Fri, 6 Mar 2020 20:11:07 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= , Icenowy Zheng , Enric Balletbo i Serra , Vasily Khoruzhick , Enric Balletbo Serra , Jernej Skrabec , Nicolas Boichat , Laurent Pinchart , Neil Armstrong , David Airlie , Torsten Duwe , Jonas Karlman , linux-kernel , dri-devel , Andrzej Hajda , Maxime Ripard , Hsin-Yi Wang , Matthias Brugger , Thomas Gleixner , Collabora Kernel ML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 6, 2020 at 8:07 PM Ond=C5=99ej Jirman wrote= : > > On Fri, Mar 06, 2020 at 04:53:46PM +0800, Icenowy Zheng wrote: > > =E5=9C=A8 2020-03-06=E6=98=9F=E6=9C=9F=E4=BA=94=E7=9A=84 09:46 +0100=EF= =BC=8CEnric Balletbo i Serra=E5=86=99=E9=81=93=EF=BC=9A > > > Hi Ondrej, > > > > > > On 5/3/20 20:35, Ond=C5=99ej Jirman wrote: > > > > Hi, > > > > > > > > On Thu, Mar 05, 2020 at 10:29:33AM -0800, Vasily Khoruzhick wrote: > > > > > On Thu, Mar 5, 2020 at 7:28 AM Enric Balletbo i Serra > > > > > wrote: > > > > > > Hi Vasily, > > > > > > > > > > CC: Icenowy and Ondrej > > > > > > Would you mind to check which firmware version is running the > > > > > > anx7688 in > > > > > > PinePhone, I think should be easy to check with i2c-tools. > > > > > > > > > > Icenowy, Ondrej, can you guys please check anx7688 firmware > > > > > version? > > > > > > > > i2cget 0 0x28 0x00 w > > > > 0xaaaa > > > > > > > > i2cget 0 0x28 0x02 w > > > > 0x7688 > > > > > > > > i2cget 0 0x28 0x80 w > > > > 0x0000 > > > > > > > > > > Can you check the value for 0x81 too? > > > > root@ice-pinephone [ ~ ] # i2cdump 0 0x28 > > No size specified (using byte-data access) > > WARNING! This program can confuse your I2C bus, cause data loss and > > worse! > > I will probe file /dev/i2c-0, address 0x28, mode byte > > Continue? [Y/n] > > 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef > > 00: aa aa 88 76 ac 00 00 00 00 00 00 00 00 00 05 05 ???v?.........?? > > 10: 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0............... > > 20: 00 00 00 00 00 00 00 00 00 00 00 24 f2 e4 ff 00 ...........$??.. > > 30: 06 40 00 04 94 11 20 ff ff 03 00 bf ff ff 10 01 ?@.??? ..?.?..?? > > 40: 72 a4 00 09 00 08 05 84 15 40 17 00 00 0a 00 e0 r?.?.????@?..?.? > > 50: 00 00 00 0a 10 00 e0 df ff ff 00 00 00 10 71 00 ...??.??.....?q. > > 60: 10 10 04 29 2d 21 10 01 09 13 00 03 e8 13 88 00 ???)-!????.????. > > 70: 00 19 18 83 16 5c 11 00 ff 00 00 0d 04 38 42 07 .????\?....??8B? > > 80: 00 00 00 00 00 74 1b 19 44 08 75 00 00 00 00 00 .....t??D?u..... > > 90: 01 02 00 00 00 00 03 00 ff 30 00 59 01 00 00 00 ??....?..0.Y?... > > a0: 00 ff fe ff ff 00 00 00 00 00 00 00 00 00 00 02 ..?............? > > b0: 00 00 00 00 00 00 40 00 28 00 00 00 00 44 08 00 ......@.(....D?. > > c0: 00 00 00 00 80 00 10 01 0a 10 18 00 00 fd 00 00 ....?.?????..?.. > > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > > e0: 50 10 08 50 00 02 00 70 00 00 30 10 0b 02 1c 01 P??P.?.p..0????? > > f0: 00 0b 07 00 94 11 7f 00 00 00 00 00 00 01 0e ff .??.???......??. > > My values for 0x28 address match this. ^ What about the values at 0x2c? > Interesting that it returns different register values for different > device addresses. Yes the registers have different meanings for the 2 addresses. Thanks,