From: Nicolas Boichat <drinkcat@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Leilk Liu <leilk.liu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-spi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: single device does not require cs_gpios
Date: Thu, 5 Nov 2015 18:33:04 +0800 [thread overview]
Message-ID: <CANMq1KCXPjQuJUp3zOSVQQA29n9TT56Z0NPpD4o3O5s3o3nqSA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfAHyTOpWcTh6w2EhEy73xfUYX5T3tpXbUbBiU-tjaZnQ@mail.gmail.com>
On Thu, Nov 5, 2015 at 5:16 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Nov 5, 2015 at 7:50 AM, Nicolas Boichat <drinkcat@chromium.org> wrote:
[...]
>> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
>> index 563954a..f694031 100644
>> --- a/drivers/spi/spi-mt65xx.c
>> +++ b/drivers/spi/spi-mt65xx.c
>> @@ -410,7 +410,7 @@ static int mtk_spi_setup(struct spi_device *spi)
>> if (!spi->controller_data)
>> spi->controller_data = (void *)&mtk_default_chip_info;
>>
>> - if (mdata->dev_comp->need_pad_sel)
>> + if (mdata->dev_comp->need_pad_sel && spi->cs_gpio >= 0)
>
> gpio_is_valid() ?
Yes, thanks! Will fix in next round. (there is a few other ones in
driver/spi/* that should probably be fixed too...)
Best,
prev parent reply other threads:[~2015-11-05 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 5:50 [PATCH] spi: mediatek: single device does not require cs_gpios Nicolas Boichat
2015-11-05 9:16 ` Andy Shevchenko
2015-11-05 10:33 ` Nicolas Boichat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANMq1KCXPjQuJUp3zOSVQQA29n9TT56Z0NPpD4o3O5s3o3nqSA@mail.gmail.com \
--to=drinkcat@chromium.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).