From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B61C33CB6 for ; Tue, 21 Jan 2020 04:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F66622522 for ; Tue, 21 Jan 2020 04:37:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y437XdOv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbgAUEh0 (ORCPT ); Mon, 20 Jan 2020 23:37:26 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:45868 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728760AbgAUEh0 (ORCPT ); Mon, 20 Jan 2020 23:37:26 -0500 Received: by mail-qv1-f68.google.com with SMTP id l14so837787qvu.12 for ; Mon, 20 Jan 2020 20:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tE6t4zYqaVXPST4AhwIQ9GsXTC/ddB8hjT5O44X4X2A=; b=Y437XdOv0Hto2lq+dzGstZ/dDsYcyHpK4I+DVf73M1v48j1EjilwkEp0HlSg8Iu9gL 0tTOS38rUYrM9yCpro7VwAwprgAfaJvNt0icSyt0cimanM+SnEp2Xre2R1C/rtGm8iVZ lRVWu7xtrpg+9KP77O5tLZX+QnE1zQQIxeaZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tE6t4zYqaVXPST4AhwIQ9GsXTC/ddB8hjT5O44X4X2A=; b=VH5/wVDrQ6DpAMF0M8fVmwSaxCnFDZEGTqoOuI9dXfwgTG+5vxD8ofOrAvUro7l/xB eC5t5iY1bQFuV9j1jbvln7BSrNmRgu5H4+MsMXlfrS48um6Yy4+YGQTr1XxtDhRcREf0 x0C4rTqRK/gNkLnpyPs5+03akGCnVNl24LvTS2EGbmtxAqRLT5oKRMdwA128FU/hDXgL 4IVdSJoE0o1qh4sTLlBwDkhDQ8j5Nt/UwkqxBMFK3CQu5caG3L+Ea3Be4zYQMuSLHOsJ fOPXpPS25cv59QFwmDSpaoMIPqKzHVjzVoP0IjwfGDWCzJCpAy2AG4H6NdA7cACRt8DJ Z13g== X-Gm-Message-State: APjAAAV+X/7V8DlRvZ+qIhyZ1ESB5NuRf+O6UNrKUYdUzIAeH1POjuqe DCa/1kGc94eTs55LStVQq/WkgqK8qebEsI0M9bfkpA== X-Google-Smtp-Source: APXvYqzdl4VdxIrAynyQuScJnrpT9ZczyRYljUJVkw1OCPfHpQClTp+aKVQtQGPPLLXXuyebvlkJ/h7fxsuCkIoPT4Y= X-Received: by 2002:a0c:f703:: with SMTP id w3mr3120793qvn.6.1579581445521; Mon, 20 Jan 2020 20:37:25 -0800 (PST) MIME-Version: 1.0 References: <20200114071602.47627-1-drinkcat@chromium.org> <20200114071602.47627-5-drinkcat@chromium.org> <20200114151643.GW3897@sirena.org.uk> In-Reply-To: <20200114151643.GW3897@sirena.org.uk> From: Nicolas Boichat Date: Tue, 21 Jan 2020 11:37:14 +0700 Message-ID: Subject: Re: [PATCH v3 4/7] drm/panfrost: Add support for multiple regulators To: Mark Brown Cc: Rob Herring , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2020 at 10:16 PM Mark Brown wrote: > > On Tue, Jan 14, 2020 at 03:15:59PM +0800, Nicolas Boichat wrote: > > > - I couldn't find a way to detect the number of regulators in the > > device tree, if we wanted to refuse to probe the device if there > > are too many regulators, which might be required for safety, see > > the thread on v2 [1]. > > You'd need to enumerate all the properties of the device and look > for things matching *-supply. I see ,-) I was hoping for something slightly cleaner, or maybe an existing function in the core. Steven: How strongly do you feel about this? If so I can add that check in the next revision. Also, just a heads-up, I'm out for the next 2 weeks, I'll send v4 after that. > > Reviewed-by: Mark Brown