From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD9EC4CEC9 for ; Wed, 18 Sep 2019 22:17:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFD9321848 for ; Wed, 18 Sep 2019 22:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dMdPuvnu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388426AbfIRWRB (ORCPT ); Wed, 18 Sep 2019 18:17:01 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:46874 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388415AbfIRWRA (ORCPT ); Wed, 18 Sep 2019 18:17:00 -0400 Received: by mail-qk1-f195.google.com with SMTP id 201so1128136qkd.13 for ; Wed, 18 Sep 2019 15:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0PPXvm1cuehURA0N+v3AsPltzXl1NumjZq3ILhmZMms=; b=dMdPuvnuN5vp6xMI9L71hDEjwqbovQsooxEY4jGDiBlLoWo++CWSdUSKnVlCsFoOMZ 8R76lKikTLgxWytd/PlmDEWQJojn+SgrdcPBATWd0xF0saUzsjEYCqg+8fkJK++UYX6J WbNN6250Qr3DBMubRt6RXyQUWvTAnGyKl9g/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0PPXvm1cuehURA0N+v3AsPltzXl1NumjZq3ILhmZMms=; b=niUlJXZtsQGzBbreIPAbi48oqyfUD6ZOuEiQE3bMBMW7faZCC0oGXWXd1GjHkNWSiv ecy/ezghqrKR6c9XYw13JW0gOq6xAuH1L8W6y/wDcHCOdMzCDCH0MyzXhjhzWVu55cF4 FoFLavt3gkwW1VbGBRwEB3PhmpQl/w9XpuZZMLlmUOB6XI6FxKCevqfBeLep8hYiRHbs B7aBCXswWL8qQSz20t5XZeDsai4GXDhhXA63mal3W/ci5QlXxDo53lKr8lcITgd6jXW0 FFS4Pm5UZANfnzg4cV94PuEdrx79WW6+QwC5rqv5WtaHTjHLIT80h8TleOWWSVZGS5Wm 3ZfQ== X-Gm-Message-State: APjAAAWkXBBsYGeiT4GtDJn5PnY0OTGUjICMEyHKgaSI6kORHm3XtKil yvwMHnm89XhcmQtkKi9z+pHVYT1Z8qxQNd/P5wnuyA== X-Google-Smtp-Source: APXvYqy1nYJoXPtXOCXEoxrsdeuTJFjJNPhHGVQajEt2tyc0sllovKQyX5fysKBk+IK5lBpHsUDyK2r1oeZ1s5t/0pc= X-Received: by 2002:a37:4c54:: with SMTP id z81mr6666386qka.18.1568845019569; Wed, 18 Sep 2019 15:16:59 -0700 (PDT) MIME-Version: 1.0 References: <20190905081546.42716-1-drinkcat@chromium.org> <20190913181729.GB3115@kevin> In-Reply-To: <20190913181729.GB3115@kevin> From: Nicolas Boichat Date: Thu, 19 Sep 2019 06:16:48 +0800 Message-ID: Subject: Re: [PATCH] arm64: dts: mt8183: Add node for the Mali GPU To: Alyssa Rosenzweig Cc: Rob Herring , Matthias Brugger , Mark Rutland , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" , Nick Fan , Boris Brezillon , Douglas Anderson , Dominik Behr Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Rob and Alyssa. +Douglas Anderson +Dominik Behr who may be interested (if not already aware) On Sat, Sep 14, 2019 at 2:17 AM Alyssa Rosenzweig wrote: > > > > > The binding we use with out-of-tree Mali drivers includes more > > > > clocks, I assume this would be required eventually if we have an > > > > in-tree driver: > > > > > > We have an in-tree driver... > > > > Right but AFAICT it does not support Bifrost GPU (yet?). > > By the time MT8183 shows up in more concrete devices, it will, certainly > in kernel-space and likely in userspace as well. At present, the DDK can > be modified to run on top of the in-tree Mali drivers, i.e. "Bifrost on > mainline linux-next (+ page table/compatible patches), with blob > userspace". > > While the open userspace isn't ready here quite yet, I would definitely > encourage upstream kernel for ChromeOS, since then there's no need to > maintain the out-of-tree GPU driver. That's an interesting idea, I had no idea, thanks for the info! Would that work with midgard as well? We have released hardware with RK3288/3399, so it might be nice to experiment with these first. > > --- > > More immediately, per Rob's review, it's important that the bindings > accepted upstream work with the in-tree Bifrost driver. Conceptually, > once Mesa supports Bifrost, if I install Debian on a MT8183 board, > everything should just work. I shouldn't need MT-specific changes / need > to change names for the DT. Regardless of which kernel driver you end up > using, minimally sharing the DT is good for everyone :-) Yes. I'll try to dig further with MTK, but this may take some time. > > -Alyssa